How to create registration objects #1445
Conversation
docs/index.bs
Outdated
| 1. If |objectMap|[|registration|] does not [=map/exist=], then: | ||
| 1. Let |registrationObject| be a new {{ServiceWorkerRegistration}} in |environment|'s [=environment settings object/Realm=]. | ||
| 1. Set |registrationObject|'s [=ServiceWorkerRegistration/service worker registration=] to |registration|. | ||
| 1. Set |registrationObject|'s {{ServiceWorkerRegistration/installing}} attribute to null if |registration|'s [=service worker registration/installing worker=] is null, otherwise the result of [=getting the service worker object=] that represents |registration|'s [=service worker registration/installing worker=] in |environment|. |
There was a problem hiding this comment.
I think this is a run-on sentence. I was once told the spec convention is "to X, if Y, and Z otherwise".
There was a problem hiding this comment.
Ugh really? I kinda hate that form since you have to read on to realise it's an "otherwise". But I guess the real problem here is it's too long for a one-liner. I'll split it up.
There was a problem hiding this comment.
Thanks, splitting it up is good too. I was just remembering whatwg/html#3891 (comment). I think just adding "and" before "otherwise" would work as well too: "if Y, and otherwise Z".
docs/index.bs
Outdated
| </section> | ||
| </section> | ||
|
|
||
| A {{ServiceWorkerRegistration}} has a <dfn for="ServiceWorkerRegistration">service worker registration</dfn> (a [=/service worker registration=]). |
There was a problem hiding this comment.
Could this sentence go above this section? Since the algorithm above refers to this definition.
There was a problem hiding this comment.
Oh yes. No idea why I put it here.
docs/index.bs
Outdated
| 1. Resolve |promise| with the {{ServiceWorkerRegistration}} object which represents |registration|. | ||
| 1. Else: | ||
| 1. Resolve |promise| with undefined. | ||
| 1. If |registration| is null, resolve |promise| with undefined, else resolve |promise| with the result of [=getting the service worker registration object=] that represents |registration| in |promise|'s [=relevant settings object=]. |
There was a problem hiding this comment.
I'm not sure this if/else construction is conventional. How about splitting it to two statements or else doing the: "Resolve |promise| with undefined, if |registration| is null, and the result of getting the registration... otherwise."
There was a problem hiding this comment.
I'll split it into two steps
As I did with service worker objects, I made it more formal with registrations too.
I'll merge to v1 once we're happy with this.
Preview | Diff