Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visual content indicators section #118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mattgarrish
Copy link
Member

@mattgarrish mattgarrish commented Nov 25, 2024

This is my best attempt to try and address the issue raised in w3c/epub-specs#2653

I've taken all the access modes that are describing visual content and created a new section called "Visual content indicators" for them. I've tried to explain that these are expanding on access mode visual but also caution that "visual" should always be set with them.

That's the best I can think of to avoid removing or deprecating them, but other ideas welcome.

I've also standardized the casing of the section titles and added a change log for 2024 (with the missed entry for the descriptor mechanism we added over the summer).


💥 Error: 500 Internal Server Error 💥

PR Preview failed to build. (Last tried on Nov 25, 2024, 2:37 PM UTC).

More

PR Preview relies on a number of web services to run. There seems to be an issue with the following one:

🚨 Spec Generator - Spec Generator is the web service used to build specs that rely on ReSpec.

🔗 [Related URL]([object Object])

Timed out after waiting 30000ms

If you don't have enough information above to solve the error by yourself (or to understand to which web service the error is related to, if any), please file an issue.

@mattgarrish
Copy link
Member Author

mattgarrish commented Nov 25, 2024

pr-preview seems to be offline, so here are alternative preview and diff links:


Preview | Diff

@mattgarrish
Copy link
Member Author

Hm, the diff isn't working in the above comment, either. Looks like a w3c service is down. Whenever it comes back up, the link should work again, though.

Copy link
Collaborator

@madeleinerothberg madeleinerothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great -- thanks Matt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants