Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2-maker Changes #990

Closed
wants to merge 7 commits into from
Closed

V2-maker Changes #990

wants to merge 7 commits into from

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Sep 25, 2023 •
edited
Loading

Preview Tests

  • Removes whitespace in support.json
  • Replaces instances of commands being created with text that violates the expectations of the new commands.json. Examples:
    • Instances of 'one' or 'two', with their numerical values. shift+one or two isn't a command that can be translated with the new commands.json and is coming from the current keys.mjs declarations.
    • Instances of caps with capsLock
    • Instances of numpad+<digit> with numpad<digit>
  • Handles unexpected cases of harder to process whitespaces coming from the original *.csvs
  • Address cases where tests weren't being properly created because of the assumption that a VoiceOver test existed for every v1 test

@howard-e howard-e requested a review from mcking65 September 25, 2023 15:30
howard-e
howard-e commented Sep 26, 2023
View reviewed changes
tests/support.json Outdated Show resolved Hide resolved
tests/support.json Outdated Show resolved Hide resolved
howard-e
howard-e commented Oct 12, 2023
View reviewed changes
scripts/v2maker.js Outdated
Comment on lines 422 to 431
const v2uniqueTestRows = [];
const seenTestIds = new Set();

for (const row of v2testRows) {
if (!seenTestIds.has(row.testId)) {
v2uniqueTestRows.push(row);
seenTestIds.add(row.testId);
}
}
v2testRows = v2uniqueTestRows;
Copy link
Contributor Author

@howard-e howard-e Oct 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existence of a VoiceOver test row was being used to assume that the equivalent JAWS + NVDA row existed, to then create v2testRows. But that wasn't always the case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block has been updated as it was leaking in instances of reading and interaction in the titles of the outputted files but the reasoning remains the same.

@howard-e howard-e mentioned this pull request Oct 12, 2023
Merged
howard-e added a commit that referenced this pull request Nov 2, 2023
@howard-e
Fix case where titles and instructions were still unexpectedly refere…
13d4597 
…ncing reading and interactions modes in v2maker script. This work has been duplicated in #990
howard-e added a commit that referenced this pull request Nov 30, 2023
@howard-e @mcking65 @stalgiag
Support V2 Test Format build (#997)
138d026 
* Add scripts to convert a test plan from v1 to v2 format

* Add and revise support and commands JSON data

support.json:
* add strings to support screen reader settings and assertion tokens.
* Add URL data for ARIA and HTML-AAM specifications.

commands.json: Add all the command string representations necessary for the new V2 test format.

* WIP: Building test index page

* Adding additional TODOs to be covered; start to addressing review page

* Fix references after rebase

* Add additional data validations

* Use MUST/SHOULD/MAY on review page

* Update validations

* Now accounting for modeless ATs

* Additional validations

* Accounting for assertionExceptions

* Additional validations and accounting for assertionExceptions; review page format now also matches 977

* Keys handling in test-io-format.mjs

* Update support.json

* Remove 'v2-made' files

* Change 'NA' for modeless to 'defaultMode'

* Format .mjs files

* Fix lines in keys.mjs

* Remove create-example-tests2

* Revert keys.mjs quotations

* assertionTokens replacement

* show replaced assertion tokens in reviewed tests

* Conditionally show modeInstructions

* testing

* Set mode for commandInfo

* Better support for modeless in aria-at-test-io-format.mjs and aria-at-test-run.mjs

* Better support for modeless in test-reviewer.mjs

* Formatting

* Update v2maker to create a new row for commands previously defined as 'F / Shift + F' for eg.

* Avoid setupScript thrown error when looking for script file

* Formatting test-reviewer.mjs

* Handle unexpected cases with v2 maker related scripts

* Handle thrown error csv properties to pass validations (for now)

* Additional cleanup

* Fix pattern name identifier on index pagae

* Formatting

* Handle all 'at'-commands.csv files without looking specifically for known ats

* Additional error handling for missing at-commands.csv files

* Update jsdocs

* Formatting

* Conditionally build v2 over v1 test format

* Refactor name for clarity

* Edge case handling for test with multiple settings

* Optimize edge case handling

* Misc

* Fix showing mode instructions on review page

* Update validations

* Update error message

* Revert changes in package.json

* Fix issues with Delete command validation

* Remove unused function

* Ensure rows in *-commands.csv are maintained by the presentationNumber

* Fix case where titles and instructions were still unexpectedly referencing reading and interactions modes in v2maker script. This work has been duplicated in #990

* Fix review page to stop using generated commandPresentationNumbers

* Update aria-at-test-run.mjs to drop support for generated command sequence numbers

* Better support of 0-level assertion exceptions on review page

* Fix linter

* Remove 'modes' from v2 test file names

* Remove comment

* Add mode to individual *.collected.(json|html) files

* Fix '1 test's'' editorial error on review page

* Fix for presenting .collected.html when needed

* Add support for multiple settings with .collected

* Don't show assertionPhrase column on review page for v1 build

* Fix when commandListSettingsPreface gets appended

* Change from {at}-{settings} .collected files to a single {at} .collected file which covers all settings

* Fix combined .collected.(json|logic)

* Update results collection form to support pass/fail assertion verdicts (#1003)

* Initial rendering pass

* Initial interaction with assertion checkbox

* Cleanup and use assertionResponseQuestion

* Remove unused required validation, Ensure input fires state change event

* Use assertionResponseQuestion in v1 tests as well

---------

Co-authored-by: Matt King <a11yThinker@gmail.com>
Co-authored-by: Stalgia Grigg <stalgia@bocoup.com>
Co-authored-by: Stalgia Grigg <stalgia.grigg@gmail.com>
@howard-e
Copy link
Contributor Author

Closing as changes included in #997.

@howard-e howard-e closed this Nov 30, 2023
howard-e added a commit that referenced this pull request Nov 30, 2023
@howard-e
Fix case where titles and instructions were still unexpectedly refere…
4be4f4e 
…ncing reading and interactions modes in v2maker script. This work has been duplicated in #990
howard-e added a commit that referenced this pull request Nov 30, 2023
@howard-e
Fix case where titles and instructions were still unexpectedly refere…
193f0d1 
…ncing reading and interactions modes in v2maker script. This work has been duplicated in #990
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 Awaiting requested review from mcking65

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@howard-e