-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Image Carousel Example: Use button elements for slide controls and make rotation control always visible #1007
Labels
enhancement
Any addition or improvement that doesn't fix a code bug or prose inaccuracy
Example Page
Related to a page containing an example implementation of a pattern
Milestone
Comments
sh0ji
added
enhancement
Any addition or improvement that doesn't fix a code bug or prose inaccuracy
bug
Code defects; not for inaccurate prose
and removed
bug
Code defects; not for inaccurate prose
labels
Apr 9, 2019
1 task
mcking65
added
Example Page
Related to a page containing an example implementation of a pattern
and removed
bug
Code defects; not for inaccurate prose
labels
Apr 23, 2019
mcking65
changed the title
add visible pause icon to auto-rotating carousel example
Image Carousel Example: Use button elements for slide controls and make rotation control always visible
Apr 23, 2019
mcking65
pushed a commit
that referenced
this issue
Jul 11, 2019
…ntrol always visible (pull #1018) Resolves issue #1007 by: * making the stop/start rotation button always visible. * Using button elements instead of links for the next and previous slide controls. Also: * Allows user to change between 2 view options: one with controls and captions overlayed on the images and one with them outside the image frames. * Improves documentation in the accessibility features section. * Adds regression tests.
Now resolved with commit 0ba3c1c. Thank you @jongund!! The updated carousel can be viewed in the latest editor's draft here: |
michael-n-cooper
pushed a commit
that referenced
this issue
Jul 11, 2019
Image Carousel Example: Use buttons for controls and make rotation control always visible (pull #1018) Resolves issue #1007 by: * making the stop/start rotation button always visible. * Using button elements instead of links for the next and previous slide controls. Also: * Allows user to change between 2 view options: one with controls and captions overlayed on the images and one with them outside the image frames. * Improves documentation in the accessibility features section. * Adds regression tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
Any addition or improvement that doesn't fix a code bug or prose inaccuracy
Example Page
Related to a page containing an example implementation of a pattern
Based on feedback in issue #971, revise the Feb 7, 2019 version of the Auto-Rotating Image Carousel Example
so the pause button is always visible and the slide controls are implemented with button elements.
Preview Link
The revised carousel can be seen in the issue1007-visible-pause-carousel branch.
The text was updated successfully, but these errors were encountered: