Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run regression tests in Chrome and Safari in addition to Firefox #1117

Open
nschonni opened this issue Jul 26, 2019 · 2 comments
Open

Run regression tests in Chrome and Safari in addition to Firefox #1117

nschonni opened this issue Jul 26, 2019 · 2 comments
Labels
regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo

Comments

@nschonni
Copy link
Contributor

I do think there is value in testing Chrome and Safari -- we could catch browser bugs :) Browsers aren't perfect and we don't know what browser people will be looking at the example from.

Originally posted by @spectranaut in #1116 (comment)

@nschonni
Copy link
Contributor Author

Might need to take another parameter to the test, or possibly sniff to see if the browser is installed

if (!coverageReportRun) {
test.before(async (t) => {
geckodriver = await startGeckodriver(1022, 12 * 1000);
session = new webdriver.Builder()
.usingServer('http://localhost:' + geckodriver.port)
.withCapabilities({
'moz:firefoxOptions': {
args: firefoxArgs
}
})
.forBrowser('firefox')
.build();
await session;
});
test.beforeEach((t) => {
t.context.session = session;
t.context.waitTime = testWaitTime;
});
test.after.always(() => {
return Promise.resolve(session && session.close())
.then(() => geckodriver && geckodriver.stop());
});
}

Travis config is here:

@nschonni
Copy link
Contributor Author

nschonni commented Oct 8, 2019

Another alternate might be https://saucelabs.com/solutions/open-source since then IE11 could also be tested

@zcorpan zcorpan added the regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo label Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo
Projects
None yet
Development

No branches or pull requests

2 participants