Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Try Headless Firefox #1116

Closed
wants to merge 1 commit into from
Closed

chore: Try Headless Firefox #1116

wants to merge 1 commit into from

Conversation

nschonni
Copy link
Contributor

@nschonni nschonni commented Jul 26, 2019

Trying the config from https://docs.travis-ci.com/user/gui-and-headless-browsers/#using-the-firefox-addon-in-headless-mode
Probably don't need "latest", but 60.0.2 is behind the latest ESR now, and is also about to bump https://www.mozilla.org/en-US/firefox/organizations/
Edit: Looks like this probably overlaps with

const firefoxArgs = process.env.CI ? [ '-headless' ] : [];

@nschonni
Copy link
Contributor Author

@spectranaut do you think there is value in adding jobs to test in Chrome and Safari?

@spectranaut
Copy link
Contributor

I do think there is value in testing Chrome and Safari -- we could catch browser bugs :) Browsers aren't perfect and we don't know what browser people will be looking at the example from.

@nschonni
Copy link
Contributor Author

Sounds good. I spun up the issue for now, but maybe i'll wait till your other improvements are in before sending a PR (if you don't beat me to it)

@nschonni
Copy link
Contributor Author

nschonni commented Jul 26, 2019

@spectranaut looks like it sped up the runs a little bit, but since it didn't run the regression checks, maybe I should touch something so that the tests are run

@spectranaut
Copy link
Contributor

Sorry this fell by the wayside for so long, @nschonni -- but you are right, the CI already runs headless filefox from the line you quoted. Just double checked I didn't invent the "CI" env variable: travis docs.

We should probably set firefox to latest. I'll just close this and open a new PR since I'm here :)

@spectranaut spectranaut closed this Nov 1, 2019
@nschonni nschonni deleted the patch-1 branch August 19, 2020 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants