Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

datepicker has insufficient contrast #1170

Closed
DavidMacDonald opened this issue Sep 11, 2019 · 2 comments · Fixed by #1172
Closed

datepicker has insufficient contrast #1170

DavidMacDonald opened this issue Sep 11, 2019 · 2 comments · Fixed by #1172
Assignees
@ZoeBijl
Labels
Example Page Related to a page containing an example implementation of a pattern

Comments

@DavidMacDonald
Copy link

DavidMacDonald commented Sep 11, 2019 •
edited
Loading

Consider bumping the icon color up to past 3:1 and the header and footer blue background to 4.5:1

image

I suggest #008EA2 for the icon
and #005793 for the header and footer background.

They are fairly random value suggestions, but they at least pass.
@JAWS-test
Copy link

I have already noted most of the contrast problems: #1132

ZoeBijl added a commit that referenced this issue Sep 18, 2019
@ZoeBijl
#1170: Correct datepicker colour contrast
5e6e52e
@ZoeBijl
Copy link
Contributor

ZoeBijl commented Sep 18, 2019

Fix for this is in PR: #1172

@ZoeBijl ZoeBijl added the Example Page Related to a page containing an example implementation of a pattern label Sep 18, 2019
@ZoeBijl ZoeBijl self-assigned this Sep 18, 2019
ZoeBijl added a commit that referenced this issue Oct 8, 2019
@ZoeBijl
#1170: Correct datepicker colour contrast
8b9e6aa
@ZoeBijl ZoeBijl mentioned this issue Oct 9, 2019
Merged
ZoeBijl added a commit that referenced this issue Oct 25, 2019
@ZoeBijl
Datepicker Example: Correct colour contrast (issue #1170)
bdc8b77
michael-n-cooper pushed a commit that referenced this issue Oct 25, 2019
Generated by TRAVIS-CI bdc8b77
7d2fbaf 
Datepicker Example: Correct colour contrast (issue #1170)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ZoeBijl ZoeBijl

Labels
Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Datepicker Example: Increase colour contrast ratio to pass WCAG (#1170) w3c/aria-practices
3 participants
@DavidMacDonald @ZoeBijl @JAWS-test