Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combobox Examples: Make compatible with touch-based screen readers #1267

Closed
mcking65 opened this issue Nov 14, 2019 · 4 comments · Fixed by #2086
Closed

Combobox Examples: Make compatible with touch-based screen readers #1267

mcking65 opened this issue Nov 14, 2019 · 4 comments · Fixed by #2086
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern Touch Related to gap in guidance about touch interaction in user interfaces
Milestone
1.2 Release 1

Comments

@mcking65
Copy link
Contributor

mcking65 commented Nov 14, 2019 •
edited by carmacleod
Loading

In review of #1255, issues with iOS VO were discovered.

Test with iOS VO and resolve issues.

Edit: Specifically, from Sarah's review in #1255:

iOS + VoiceOver: the "open" button did not work (didn't open the listbox, and sent the cursor back to the text input). I'd suggest either making the open button aria-hidden="true" tabindex="-1", or removing it altogether.

Reply from Matt:

Surprising suggestion. How would touch users expand/collapse the combobox if it is not accessible?
This is a widget that we should make touch compatible before APG 1.2 release. Opened #1267.
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern Touch Related to gap in guidance about touch interaction in user interfaces labels Nov 14, 2019
@mcking65 mcking65 added this to the 1.2 Release 1 milestone Nov 14, 2019
This was referenced Nov 14, 2019
Closed
Merged
@carmacleod carmacleod mentioned this issue May 13, 2020
Merged
6 tasks
@jongund jongund linked a pull request Nov 1, 2021 that will close this issue
Combobox Autocomplete Example: Use pointer events instead of mouse events #2086
Merged
@a11ydoer
Copy link
Contributor

a11ydoer commented Nov 2, 2021 •
edited
Loading

Using pointer events in APG has been working well to resolve touch issue. thanks, @jongund

@a11ydoer
Copy link
Contributor

a11ydoer commented Nov 2, 2021 •
edited
Loading

@jongund can you provide the example link? The example link from the issue 1255 is broken. Thanks in advance.

@jongund
Copy link
Contributor

jongund commented Nov 2, 2021

@a11ydoer There is a linked pull request #2086 to this issue, it contains the preview links for the changes.

@a11ydoer
Copy link
Contributor

a11ydoer commented Nov 2, 2021

Example links
Combobox Autocomplete: Both
Combobox Autocomplete: List
Combobox Autocomplete: None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern Touch Related to gap in guidance about touch interaction in user interfaces
Projects
None yet
Milestone
1.2 Release 1
Development

Successfully merging a pull request may close this issue.

Combobox Autocomplete Example: Use pointer events instead of mouse events w3c/aria-practices
3 participants
@jongund @mcking65 @a11ydoer