Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review editorial changes to spinbutton design pattern #222

Closed
mcking65 opened this issue Dec 13, 2016 · 4 comments
Closed

Review editorial changes to spinbutton design pattern #222

mcking65 opened this issue Dec 13, 2016 · 4 comments
Assignees
@jnurthen
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Milestone
1.1 2016Q4 PWD

Comments

@mcking65
Copy link
Contributor

The spinbutton design pattern
needed several significant changes to be consistent with APG editorial guidelines.

Please review the pattern to check for typos, misspellings, etc.

The changes are listed in the below linked commit statement.
mcking65 added a commit that referenced this issue Dec 13, 2016
@mcking65
Editorial rework of spinbutton design pattern for issue #222
b78f45e 
In the spinbutton design pattern section of aria-practices.html, made the following changes.
1. Revised introductory paragraphs to fix incomplete sentences and grammar and to better describe the distinguishing features of spinbuttons.
2. Significant restructuring and rephrasing of keyboard interaction to match APG editorial guidelines.
3. Reformatting and rephrasing of roles, states, and properties to be consistent with APG editorial guidelines.
4. Replaced links to external examples with link to issue 125.
@mcking65 mcking65 added documentation editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. labels Dec 13, 2016
@mcking65 mcking65 added this to the 1.1 Q4 PWD milestone Dec 13, 2016
@mcking65 mcking65 assigned cookiecrook and jnurthen and unassigned cookiecrook Dec 13, 2016
@jnurthen
Copy link
Member

I made some comments in the commit. I have no idea how that well that works with a screen reader though - let me know if it is a problem and I'll make them in another way.

@mcking65
Copy link
Contributor Author

I found 3 of 4 comments for which I received notifications and made changes in commit 3cb1a81.

I did not find this one in the commit:

A spinbutton can't have anything other than numbers in it IMO.
Even AM and PM are not allowed in a normal spinbutton.

Did you remove it?

The language mentioning AM and PM were part of the original text. I would assume that this is something that could only be done in a custom spinbutton as opposed to a native range input.

@jnurthen
Copy link
Member

jnurthen commented Dec 14, 2016 via email

@mcking65
Copy link
Contributor Author

@jnurthen, thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnurthen jnurthen

Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Projects
None yet
Milestone
1.1 2016Q4 PWD
Development

No branches or pull requests
3 participants
@cookiecrook @jnurthen @mcking65