Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop example of the feed pattern #246

Closed
mcking65 opened this issue Jan 19, 2017 · 1 comment
Closed

Develop example of the feed pattern #246

mcking65 opened this issue Jan 19, 2017 · 1 comment
Assignees
@mcking65
Labels
Example Page Related to a page containing an example implementation of a pattern
Milestone
1.1 APG Release 1

Comments

@mcking65
Copy link
Contributor

This issue depends on issue #245.
@mcking65 mcking65 added the Example Page Related to a page containing an example implementation of a pattern label Jan 19, 2017
@mcking65 mcking65 added this to the 1.1 PR milestone Jan 19, 2017
mcking65 added a commit that referenced this issue Feb 3, 2017
@mcking65
Feed Pattern First Draft and Example Template
f73152e 
Modified aria-practices.html:
* Added a design pattern section titled "Feed" with first draft of content.
* Added note to beginning of section with a link to issue #245 to capture feedback.

Set up example template for feed example development, which is tracked by issue #246.
new file:   examples/feed/css/feed.css
new file:   examples/feed/feed.html
new file:   examples/feed/js/feed.js
mcking65 pushed a commit that referenced this issue Mar 10, 2017
@tatermelon @mcking65
Feed Example: Add JS and Content
7ba516c 
For issue #246, add javascript and content for an example feed.
mcking65 pushed a commit that referenced this issue Apr 10, 2017
@tatermelon @mcking65
Feed Example: Fix Styling Dependency on table.css (pull #349)
207db41 
For feed example development issue #246, fix styling problems that resulted from removal of examples/css/table.css as described in issue #338.

This fixes infinite scroll FF.
@mcking65 mcking65 modified the milestones: 1.1 Rec, 3Q17 Working Draft Oct 11, 2017
@mcking65 mcking65 self-assigned this Nov 27, 2017
mcking65 added a commit that referenced this issue Dec 1, 2017
@mcking65
Feed Example: Add Intro and Link to Display Page
5ba0012 
For issue #246, Write the introduction and provide a link to the page that displays the functional feed.
Unlike other examples, the example itself i on its own page.
mcking65 added a commit that referenced this issue Dec 7, 2017
@mcking65
Feed Example: Complete Documentation
346556b 
For issue #246, modified examples/feed/feed.html:
* Completed description.
* Completed keyboard documentation
* Completed roles, states, and properties documentation* Completed links to javascript and css files
* Updated HTML source section
* Added link to review issue.

Also deleted unused file examples/feed/css/feed.css.
@mcking65 mcking65 mentioned this issue Dec 7, 2017
Open
@mcking65
Copy link
Contributor Author

mcking65 commented Dec 7, 2017

First version complete with commit 346556b.

@mcking65 mcking65 closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
Example Page Related to a page containing an example implementation of a pattern
Projects
Feed Pattern and Examples Development Project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
1 participant
@mcking65