Search Landmark example has WCAG Use of Color violation

[WilcoFiers]

Spotted this when testing with axe. On the following page, under the "Definitions" header there's a link with the text "search landmarks". This link is only distinguishable from other by its blue color. This has a contrast of 2.7:1 to the black text. This should be at least 3:1, or maybe better yet the link should be underlined by default, instead of only on hover.

https://www.w3.org/WAI/ARIA/apg/example-index/landmarks/search.html

[css-meeting-bot]

The ARIA Authoring Practices (APG) Task Force just discussed Search Landmark example has WCAG Use of Color violation.

The full IRC log of that discussion

<MarkMcCarthy> TOPIC: Search Landmark example has WCAG Use of Color violation
<MarkMcCarthy> github: https://github.com//issues/2505
<MarkMcCarthy> Matt_King: is this an issue with the "search landmark" on this page?
<MarkMcCarthy> MarkMcCarthy: yes, i suspect it might be an issue with browsers, rather than our pages. the blue text is what's failing, because it's not underlined.
<MarkMcCarthy> jongund: the issue it seems is that we're not underlining links, i thought that was part of our design
<MarkMcCarthy> jongund: if the issue is just that links aren't underlined, lets just underline all links. all links in related documents are underlined, so let's make it consistent?
<MarkMcCarthy> jongund: all links in `main` content should be underlined, i'll work on that
<MarkMcCarthy> Matt_King: but in other pages, is this the same?
<MarkMcCarthy> jongund: in other pages it IS underlined - bizarre!
<MarkMcCarthy> Matt_King: not necessarily - the landmark examples don't use our templates yet.
<MarkMcCarthy> jongund: no, the other landmark examples are underlined, just search isn't.
<MarkMcCarthy> Matt_King: Oh! Then yes, if you could look into that
<MarkMcCarthy> jongund: search, assistive tech, and resources' main content links don't get underlined. every other one is
<MarkMcCarthy> Matt_King: what about pattern pages - carousel, etc.
<MarkMcCarthy> jongund: they're underlined
<MarkMcCarthy> Matt_King: so not a general template problem, something specific to a few pages
<MarkMcCarthy> jongund: maybe there's some CSS adjustment to work on, i'm on it
<MarkMcCarthy> jongund: should i make changes agaisnt main?
<MarkMcCarthy> Matt_King: yeah, i'll figure out how to merge it in
<MarkMcCarthy> Matt_King: all of the APG pages have landmark examples on them now, so we can rewrite these somehow (in the future) to leverage that

[mcking65]

Fix merged to main. Plan to go to production this week.

Thank you @WilcoFiers for reporting the problem and to @jongund for help with the fix.