Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Back to Top" link obscures modal action buttons on mobile #2842

Closed
emamoah opened this issue Oct 25, 2023 · 2 comments
Closed

"Back to Top" link obscures modal action buttons on mobile #2842

emamoah opened this issue Oct 25, 2023 · 2 comments
Labels
bug Code defects; not for inaccurate prose Feedback Issue raised by or for collecting input from people outside APG task force

Comments

@emamoah
Copy link
Contributor

emamoah commented Oct 25, 2023

This is from the Modal Dialog Example in the APG.

It may require an increase in the bottom padding on all modals (for uniformity)

Screenshot_20231025_171503_Firefox.png

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Issue 2842 - Bug in modal dialog example when accessed on mobile.

The full IRC log of that discussion <jugglinmike> Topic: Issue 2842 - Bug in modal dialog example when accessed on mobile
<jugglinmike> github: https://github.com//issues/2842
<jugglinmike> Matt_King: We received both an issue and a pull request from this contributor--that's great!
<jugglinmike> Matt_King: But before we look at the patch, we should agree on whether this is truly a bug as raised
<jugglinmike> siri: It is somewhat subjective
<jugglinmike> Matt_King: can others reproduce whatever is in the provided screen shot?
<jugglinmike> [the group works to reproduce the problem, eventually discovering that is occurs in a nested modal dialog]
<jugglinmike> jongund: There appears to be an unrelated problem--with touch, I can't close the dialog
<jugglinmike> howard-e: I can reproduce that, jongund
<jugglinmike> Jem: The patch solves the "obscuring button" problem. I'm using my mouse to confirm this, so I can't confirm touch
<jugglinmike> howard-e: I can confirm the fix as well. It also fixes "touch" for me (I'm using a simulated version of touch with my browser's developer tools)
<jugglinmike> howard-e: The best confirmation will be from a true mobile device
<jugglinmike> Matt_King: I think I can merge this fix because it is so simple. Even if it doesn't address the problem that jongund reported, I think it would still be worth merging
<jugglinmike> jongund: I can't verify with my phone right now
<jugglinmike> Zakim, end the meeting

@mcking65
Copy link
Contributor

Thank you @emamoah for raising and providing the fix for this issue!!!!

I just merged #2843, and it will be included in our next site update, which is scheduled for tomorrow.

@mcking65 mcking65 added bug Code defects; not for inaccurate prose Feedback Issue raised by or for collecting input from people outside APG task force labels Dec 11, 2023
@mcking65 mcking65 added this to the H2/2023 Content Updates milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Code defects; not for inaccurate prose Feedback Issue raised by or for collecting input from people outside APG task force
Development

No branches or pull requests

3 participants