Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update patterns that prescribe use of aria-haspopup to include appropriate mentions of new token values #347

Closed
DavidMacDonald opened this issue Mar 27, 2017 · 3 comments
Closed

Update patterns that prescribe use of aria-haspopup to include appropriate mentions of new token values #347

DavidMacDonald opened this issue Mar 27, 2017 · 3 comments
Labels
Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question
Milestone
1.1 APG Release 1

Comments

@DavidMacDonald
Copy link

It appears the latest wai-aria spec has changed aria-haspoup="true" to more granular values:

... Authors must ensure that the role of the element that serves as the container for the popup content is menu, listbox, tree, grid, or dialog, and that the value of aria-haspopup matches the role of the popup container...To provide backward compatibility with ARIA 1.0 content, user agents must treat an aria-haspopup value of true as equivalent to a value of menu. https://www.w3.org/TR/wai-aria-1.1/#aria-haspopup

So shouldn't we provide those values for aria-haspopup?
@mcking65 mcking65 added documentation Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question labels Jul 15, 2017
@mcking65 mcking65 added this to the 1.1 Rec milestone Jul 15, 2017
@ZoeBijl
Copy link
Contributor

ZoeBijl commented Sep 8, 2017

We discussed this during last week’s conference call. Although for some reason I missed the last sentence in your post.

The true value isn’t deprecated. Although I do agree that we should at least mention the new values if not replace the old with the new.

Will bring up again now that I’ve actually read your post.

@mcking65 mcking65 changed the title Throughout the document aria-haspopup="true" is mentioned. Isn't that deprecated? Update patterns that prescribe use of aria-haspopup to include appropriate mentions of new token values Oct 10, 2017
@mcking65
Copy link
Contributor

mcking65 commented Oct 10, 2017 •
edited
Loading

Change title of this issue to reflect needed action.

Following updates are needed:

  1. button design pattern mentions only boolean; should also mention menu token.
  2. Menu and menubar pattern mentions only boolean; should also mention menu token.
  3. Menu button pattern mentions only boolean; should also mention menu token.
  4. Tabs pattern mentions only boolean; should also mention menu token.

Note: combobox pattern already describes use of new token values.

@mcking65 mcking65 modified the milestones: 1.1 Rec, 3Q17 Working Draft Oct 10, 2017
mcking65 added a commit that referenced this issue Nov 6, 2017
@mcking65
Design Patterns that use aria-haspopup document new token values
878d9b7 
For issue #347, change the design patterns that prescribe use of aria-haspopup to include appropriate mentions of new token values ·

 In aria-practices.html, changed the following design patterns:

*  button design pattern
*   Menu and menubar pattern
* Menu button pattern
* Tabs pattern
@mcking65
Copy link
Contributor

mcking65 commented Nov 6, 2017

@DavidMacDonald, This is resolved with commit 878d9b7.

@mcking65 mcking65 closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feedback Issue raised by or for collecting input from people outside APG task force question Issue asking a question
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
3 participants
@DavidMacDonald @ZoeBijl @mcking65