Navigation Menu Button Example should use a button element for the menu button #352
Assignees
Labels
Example Page
Related to a page containing an example implementation of a pattern
Feedback
Issue raised by or for collecting input from people outside APG task force
Milestone
Comments
mcking65
added
Example Page
|
@MichielBijl, were you planning on submitting a PR for this? If so, could it be before Oct 18? |
|
@mcking65 this was never assigned to me? But I can do it. |
ZoeBijl
pushed a commit
that referenced
this issue
Oct 13, 2017
|
Fixed in 9714cf4 |
|
@MichielBijl, thanks! I am reopening though because we still have to align the documentation on the page with the code. There is some language in the intro that needs to be edited because it mentions the button. There is also a row that needs to be removed from the states and props table and some additional rows where the element column needs to be changed from Do you have time for this too? |
mcking65
added a commit
that referenced
this issue
Nov 6, 2017
…ment For issue #352, modified examples/menu-button/menu-button-links.html to: * Change example description to state that an HTML button is used for the menu button. * Remove row for button role from roles, states, and properties table. * Update roles, states, and properties table to change the element column to say button instead of 'a'. * Moved info about button label from deleted row to a note below the table.
|
Commit 9597648 wraps this up. |
github-project-automation
bot
moved this to Complete
in Menu, Menubar, and Menu Button patterns and examples development project
github-project-automation
bot
moved this to Complete
in Command, Toggle, Menu, and Disclosure Button Patterns and Examples Development Project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The Navigation Menu Button Example shows a menu button containing a menu of links.
For some reason, the button itself ("WAI-ARIA Quick Links") uses an
<a>element and adds a role of "button", but this does not seem correct to me - I think it should just use a button element.The test of whether or not to use an anchor element is this: "Will the user ever want to open this thing in a new browser tab or window?" If the answer is, "No", then it does not make sense to use an element that can be right-clicked and have the browser's context menu contain items such as: "Open link in new tab", "Open link in new window", etc. Please just use a button element for the "WAI-ARIA Quick Links" button.
(The menu items are ok as links - it is only the menu button that should not be a link).
The text was updated successfully, but these errors were encountered: