Tree View Examples: Fix Incorrect Left Arrow Behavior

[mcking65]

In all four treeview examples, if focus is on a child node and left arrow is pressed, focus moves to the parent and the parent node is closed. In this circumstance, the focus should move but the parent node should remain open. A parent node should close only if focus is on the parent node when left arrow is pressed.

[jongund]

I made a pull request this morning that I believe fixed the bug with left arrow key collapsing the leaf when not on an expandable treeitem.

[mcking65]

@jongund, this bug is indeed fixed with pull #374. Many thanks!!

[mcking65]

@jongund, Oops, this issue is not quite resolved.

If the focus is on a level two or deeper parent node that is closed, pressing left arrow moves to the parent of the parent node and closes the branch. For example, in the
file viewer tree,
navigate to reports, expand with right, move down to the first child (reports-1), then press left arrow. Focus moves to the reports parent, like it should. However, the reports branch also closes, which it should not.

[jongund]

Matt, I used the left arrow key to move focus from one of the lowest level treeitems to its parent treeitem and it just moved focus to the parent for me and did not close the leaf with the child treeitems. I press left arrow again then it closed the leaf. I tired if for all the examples: http://w3c.github.io/aria-practices/examples/treeview/treeview-1/treeview-1a.html http://w3c.github.io/aria-practices/examples/treeview/treeview-1/treeview-1b.html http://w3c.github.io/aria-practices/examples/treeview/treeview-2/treeview-2a.html http://w3c.github.io/aria-practices/examples/treeview/treeview-2/treeview-2b.html Jon From: Matt King <notifications@github.com> Reply-To: w3c/aria-practices <reply@reply.github.com> Date: Wednesday, April 26, 2017 at 5:58 PM To: w3c/aria-practices <aria-practices@noreply.github.com> Cc: Jon Gunderson <jongund@illinois.edu>, Mention <mention@noreply.github.com> Subject: Re: [w3c/aria-practices] Tree View Examples: Fix Incorrect Left Arrow Behavior (#365) @jongund<https://github.com/jongund>, Oops, this issue is not quite resolved. If the focus is on a level two or deeper parent node that is closed, pressing left arrow moves to the parent of the parent node and closes the branch. For example, in the file viewer tree<http://w3c.github.io/aria-practices/examples/treeview/treeview-1/treeview-1a.html>, navigate to reports, expand with right, move down to the first child (reports-1), then press left arrow. Focus moves to the reports parent, like it should. However, the reports branch also closes, which it should not. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#365 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABcE7KQrDFAZzLcbPmkhlLEnQyLEvPucks5rz8wYgaJpZM4NCmnT>.

[mcking65]

@jongund, the problem only occurs if the focus is on a level 2 or greater parent node that is closed as I described above. In the structures we have in the examples, this condition only exists for the immediate children of the reports and letters branches in the file viewer trees.

[jongund]

Matt, I see it now and will fix it. Jon From: Matt King <notifications@github.com> Reply-To: w3c/aria-practices <reply@reply.github.com> Date: Thursday, April 27, 2017 at 3:10 AM To: w3c/aria-practices <aria-practices@noreply.github.com> Cc: Jon Gunderson <jongund@illinois.edu>, Mention <mention@noreply.github.com> Subject: Re: [w3c/aria-practices] Tree View Examples: Fix Incorrect Left Arrow Behavior (#365) @jongund<https://github.com/jongund>, the problem only occurs if the focus is on a level 2 or greater parent node that is closed as I described above. In the structures we have in the examples, this condition only exists for the immediate children of the reports and letters branches in the file viewer trees. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#365 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABcE7Iw0OKsL359mQguqRp-RWwSMQHJrks5r0E2JgaJpZM4NCmnT>.

[jongund]

Matt, I understand the bug now and it should be fixed in the latest pull request. Jon From: Matt King <notifications@github.com> Reply-To: w3c/aria-practices <reply@reply.github.com> Date: Thursday, April 27, 2017 at 3:10 AM To: w3c/aria-practices <aria-practices@noreply.github.com> Cc: Jon Gunderson <jongund@illinois.edu>, Mention <mention@noreply.github.com> Subject: Re: [w3c/aria-practices] Tree View Examples: Fix Incorrect Left Arrow Behavior (#365) @jongund<https://github.com/jongund>, the problem only occurs if the focus is on a level 2 or greater parent node that is closed as I described above. In the structures we have in the examples, this condition only exists for the immediate children of the reports and letters branches in the file viewer trees. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#365 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/ABcE7Iw0OKsL359mQguqRp-RWwSMQHJrks5r0E2JgaJpZM4NCmnT>.

[mcking65]

@jongund, thank you!! this is now fixed.