Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work on orientation for tabs #40

Closed
ZoeBijl opened this issue May 9, 2016 · 3 comments
Closed

Work on orientation for tabs #40

ZoeBijl opened this issue May 9, 2016 · 3 comments
Assignees
@mcking65
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Milestone
1.1 2016Q4 PWD

Comments

@ZoeBijl
Copy link
Contributor

ZoeBijl commented May 9, 2016 •
edited by mcking65
Loading

As discussed during telecon.

Also, when working on this, fix up/down arrow key problem described in issue #14.
@ZoeBijl ZoeBijl added Example Page Related to a page containing an example implementation of a pattern editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. and removed Example Page Related to a page containing an example implementation of a pattern labels May 9, 2016
@mcking65 mcking65 added this to the 1.1 PR milestone Aug 15, 2016
@mcking65 mcking65 mentioned this issue Aug 15, 2016
Closed
@mcking65 mcking65 modified the milestones: 1.1 Q4 PWD, 1.1 PR Aug 15, 2016
mcking65 added a commit that referenced this issue Aug 18, 2016
@mcking65
Fix keyboard, orientation, and editorial issues in tabs design pattern
424776b 
 Modified the tabs design pattern section (id="tabpanel") in aria-practices.html to:
 1. In the keyboard subsection, added a note about vertical arrow keys to address the problem described in issue #14.
2. Address vertical orientation of the tablist in the keyboard and properties guidance as described in issue #40.
3. Add guidance about the use of aria-labelledby on the tabpanel element as called for by issue #41.
4. Edit the text to be consistent with the APG editorial guidelines.
@mcking65
Copy link
Contributor

This issue is addressed in commit 424776b and can now be viewed in master at:
http://w3c.github.io/aria-practices/#tabpanel

Feedback is welcome!

@mcking65
Copy link
Contributor

Change 2nd bullet:
"When focus is on a tab element: "
To
"When focus is on a tab element in a horizontal tab list: "
And then separate the non-arrow key bullets out from that sublist.

mcking65 added a commit that referenced this issue Aug 25, 2016
@mcking65
Fixed typos and editorial issues in tabs pattern
aeab2e1 
In the tabs design pattern (id="tabpanel") section of aria-practices.html:
* Fixed typos identified by @StommePoes in issue #14.
* Fixed typos identified during August 22 APG meeting.
* Made editorial changes to make it clear that the arrow key bullets in the keyboard section describe behavior for horizontal orientation to complete changes needed for issue #40.
@mcking65
Copy link
Contributor

This issue is now fully resolved with the addition of commit aeab2e1

@aardrian aardrian mentioned this issue Jan 24, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies.
Projects
Tabs Pattern and Examples Development Project
Status: Complete
Milestone
1.1 2016Q4 PWD
Development

No branches or pull requests
2 participants
@ZoeBijl @mcking65