Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree view examples: Disable default focus ring and implement hover and focus states in css #404

Closed
mcking65 opened this issue Jun 19, 2017 · 2 comments
Closed

Tree view examples: Disable default focus ring and implement hover and focus states in css #404

mcking65 opened this issue Jun 19, 2017 · 2 comments
Assignees
@jongund
Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Milestone
1.1 APG Release 1

Comments

@mcking65
Copy link
Contributor

mcking65 commented Jun 19, 2017 •
edited
Loading

In the four tree view examples:

  1. Disable default custom focus indicator
  2. Per May 8, 2017 comment by Michiel in issue 223, instead of applying classes with js, use :hover and :focus to implement the custom focus and hover styling.
  3. Update documentation in the accessibility features section of the example pages.
@mcking65 mcking65 added Example Page Related to a page containing an example implementation of a pattern enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy labels Jun 19, 2017
@mcking65 mcking65 added this to the 1.1 Rec milestone Jun 19, 2017
@mcking65 mcking65 changed the title Tree view examples: Implement hover and focus states in css Tree view examples: Disable default focus ring and implement hover and focus states in css Jun 19, 2017
This was referenced Jun 19, 2017
Closed
Closed
Closed
@jongund
Copy link
Contributor

jongund commented Jun 19, 2017

Removed default keyboard focus styling when focus is on a tree item

mcking65 pushed a commit that referenced this issue Jun 22, 2017
@jongund @mcking65
Tree View Examples: Disable default focus ring and use images for ico…
ba5cf02 
…ns (#411)

For issue #404, this commit disables the default focus ring that was being displayed in addition to the custom focus ring.

For issue #406, this commit replaces the plus and minus characters injected with the content property with images.
mcking65 added a commit that referenced this issue Nov 21, 2017
@mcking65
Tree View Examples: Update documentation of Accessibility Features
b5400fb 
For issue #404, updated the statement in the accessibility features section
of each of the 4 tree view example pages.
Updated to document  the change to use of CSS pseudo-classes for focus and hover
made in commit  ba5cf02.
@mcking65
Copy link
Contributor Author

With commits ba5cf02 and b5400fb, this issue is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongund jongund

Labels
enhancement Any addition or improvement that doesn't fix a code bug or prose inaccuracy Example Page Related to a page containing an example implementation of a pattern
Projects
None yet
Milestone
1.1 APG Release 1
Development

No branches or pull requests
2 participants
@jongund @mcking65