Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete editorial updates to Dialog (Modal) design pattern #42

Closed
6 tasks done
ZoeBijl opened this issue May 9, 2016 · 1 comment
Closed
6 tasks done

Complete editorial updates to Dialog (Modal) design pattern #42

ZoeBijl opened this issue May 9, 2016 · 1 comment
Assignees
@mcking65
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Pattern Page Related to a page documenting a Pattern
Milestone
Jan 2017 Clean Up

Comments

@ZoeBijl
Copy link
Contributor

ZoeBijl commented May 9, 2016 •
edited by mcking65
Loading

  • Rewrite second sentence of first paragraph
  • Clarify "trap" focus; replace with more clear language about tab sequence.
  • Remove bullet for enter key from keyboard interaction
  • Remove note on pressing the escape key
  • Fix editorial consistency issues in sections on keyboard and roles/states/properties.
  • Add further guidance about initial focus. Address when content is large and first focusable element would cause top of content to scroll out of view. Possibly include note stating initial focus should go to the least destructive action, e.g., like in confirmation dialogs.
@ZoeBijl ZoeBijl added the editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. label May 9, 2016
@mcking65 mcking65 changed the title Review: Dialog (Modal) Review: Dialog (Modal) design pattern Aug 13, 2016
@mcking65 mcking65 mentioned this issue Aug 13, 2016
Closed
@mcking65 mcking65 added this to the 1.1 PR milestone Aug 13, 2016
mcking65 added a commit that referenced this issue Dec 8, 2016
@mcking65
Editorial revisions to modal dialog pattern
e2203fb 
modified aria-practices.html:
In the modal dialog pattern section,
* Fixed several of the problems marked as complete in the checklist in issue #42.
* Updated paragraph linking to issue 42.
@mcking65 mcking65 modified the milestones: Feb 2017 Heartbeat Draft, 1.1 PR Jan 7, 2017
@mcking65 mcking65 mentioned this issue Jan 18, 2017
Closed
@mcking65 mcking65 added documentation Pattern Page Related to a page documenting a Pattern labels Feb 16, 2017
@mcking65 mcking65 changed the title Review: Dialog (Modal) design pattern Complete editorial updates to Dialog (Modal) design pattern Feb 16, 2017
mcking65 added a commit that referenced this issue Mar 16, 2017
@mcking65
Complete Draft of Dialog Pattern
b59b3df 
For issue #42, made the following changes to dialog_modal section of aria-practices.html:
1. Minor editorial revisions to the introduction for clarity.
2. Made reference to nonmodal dialogs a link to the nonmodal pattern.
3. Added notes providing guidance on initial focus placement.
4. Included a link to alert dialog pattern for circumstances where the dialog is confirming a destructive action.
5. Expanded guidance for focus placement after the dialog closes.
6. Added link to review issue 325 and removed link to development issue #42.
@mcking65 mcking65 mentioned this issue Mar 16, 2017
Closed
4 tasks
@mcking65
Copy link
Contributor

This work is now complete and the review process is started in issue 325.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Pattern Page Related to a page documenting a Pattern
Projects
Dialog Patterns and Examples Development Project
Status: Complete
Milestone
Jan 2017 Clean Up
Development

No branches or pull requests
2 participants
@ZoeBijl @mcking65