Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spinbutton Pattern does not state home and end are not needed when min and max are not known #446

Closed
mcking65 opened this issue Aug 28, 2017 · 2 comments
Closed

Spinbutton Pattern does not state home and end are not needed when min and max are not known #446

mcking65 opened this issue Aug 28, 2017 · 2 comments
Assignees
@mcking65
Labels
bug Code defects; not for inaccurate prose Pattern Page Related to a page documenting a Pattern
Milestone
1.1 APG Release 1

Comments

@mcking65
Copy link
Contributor

mcking65 commented Aug 28, 2017 •
edited
Loading

Per feedback from @MichielBijl in today's Practices teleconference, The Spinbutton pattern
keyboard guidance says home set the min and max value, but do not state that this is not needed if the spinbutton does not have a min or max value.
@mcking65 mcking65 added bug Code defects; not for inaccurate prose documentation Pattern Page Related to a page documenting a Pattern labels Aug 28, 2017
@mcking65 mcking65 self-assigned this Aug 28, 2017
@mcking65 mcking65 added this to the 3Q17 Working Draft milestone Aug 28, 2017
mcking65 added a commit that referenced this issue Aug 28, 2017
@mcking65
Spinbutton Pattern: Clarify Home and End key guidance
f492516 
For issue #446, Modified the spinbutton pattern in aria-practices.html.
Added language to make it clear that
Home and End are only needed for spinbuttons that have min and max values.
@mcking65
Copy link
Contributor Author

Resolved with commit f492516.

@ZoeBijl
Copy link
Contributor

ZoeBijl commented Aug 28, 2017

That was a quick fix, nice work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
bug Code defects; not for inaccurate prose Pattern Page Related to a page documenting a Pattern
Projects
None yet
Milestone
1.1 APG Release 1
Development

No branches or pull requests
2 participants
@ZoeBijl @mcking65