Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor Menubar Example: Enter not closing menus when performing a command and aria-checked not correctly set on some items #524

Closed
mcking65 opened this issue Nov 16, 2017 · 1 comment
Closed

Editor Menubar Example: Enter not closing menus when performing a command and aria-checked not correctly set on some items #524

mcking65 opened this issue Nov 16, 2017 · 1 comment
Assignees
@sh0ji
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone
1.1 APG Release 1

Comments

@mcking65
Copy link
Contributor

This issue is for two bugs in the editor menubar example:

  1. When Enter is pressed to activate a menuitem that performs an action, e.g., change font, it should both perform the action and close the menu. In this particular example, the focus should logicaly go to the text area after the action is performed.

  2. When menuitem radios and menuitemcheckbox items are activated, sometimes the aria-checked state is not set to true. And, if a menuitemradio, the previously checked item does not get aria-checked set to false. This was working correctly prior to commit 0de93bd.
@mcking65 mcking65 added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Nov 16, 2017
@mcking65 mcking65 added this to the 1.1 APG Release 1 milestone Nov 16, 2017
@mcking65 mcking65 mentioned this issue Nov 16, 2017
Closed
3 tasks
@sh0ji sh0ji mentioned this issue Nov 17, 2017
Merged
mcking65 pushed a commit that referenced this issue Nov 17, 2017
@sh0ji @mcking65
Editor Menubar Example: set aria-checked correctly, close with enter,…
ba84ee6 
… remove redundant code (pull #525)

Change the editor menubar example to resolve issues #521 and #524:
* ensure that aria-checked is only updated on font-size elements
* apply menuitem roles to the triggering element and match menubar-1 semantics
* update styles to not rely on span selector
* always close the menu on click (keyboard or otherwise)
* don't close menu on space
@mcking65
Copy link
Contributor Author

With thanks to @sh0ji, this is resolved with commit ba84ee6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sh0ji sh0ji

Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
1.1 APG Release 1
Development

No branches or pull requests
2 participants
@mcking65 @sh0ji