Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in example: listbox/listbox-rearrangeable.html (multiselect keyboard interactions) #919

Closed
spectranaut opened this issue Oct 2, 2018 · 13 comments · Fixed by #1344
Closed

Bugs in example: listbox/listbox-rearrangeable.html (multiselect keyboard interactions) #919

spectranaut opened this issue Oct 2, 2018 · 13 comments · Fixed by #1344
Assignees
@jongund @smhigley @sh0ji
Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Milestone
1.2 Release 1

Comments

@spectranaut
Copy link
Contributor

In chrome on linux, the following key commands do not work in the second example implementation on the example page listbox/listbox-rearrangeable.html:

  • Shift + Down Arrow
    • Instead, the behavior is the same as down arrow
  • Shift + Up Arrow
    • Instead, the behavior is the same as up arrow
  • Control + Shift + Home
    • Instead, the behavior is the same as home
  • Control + Shift + End
    • Instead, the behavior is the same as end
  • Control + A
    • Instead, all of the text on the web page is selected
@mcking65 mcking65 added this to the 1.1 APG Release 4 milestone Oct 8, 2018
@annabbott annabbott added bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern labels Oct 8, 2018
@jnurthen
Copy link
Member

jnurthen commented Oct 8, 2018

(I can't get these keys to work in FF on Mac either)

@charmarkk
Copy link
Contributor

I also had this issue recently with IE and Chrome on Windows 10, as well as Safari.

@shirsha
Copy link

shirsha commented Oct 12, 2018

Sorry, I could not get to updating this issue till now.
Thanks Mark for updating it for me.

@charmarkk charmarkk mentioned this issue Dec 18, 2018
Closed
@charmarkk charmarkk mentioned this issue May 9, 2019
Closed
3 tasks
@charmarkk
Copy link
Contributor

All - Chris Mills over at MDN says this isn't an issue on MacOS any longer. I'll check into it myself, but might be worth others checking too.

@mcking65 mcking65 modified the milestones: 1.1 APG Release 4, 1.2 CR Aug 13, 2019
@carmacleod carmacleod mentioned this issue Jan 23, 2020
Closed
@a11ydoer
Copy link
Contributor

a11ydoer commented Feb 22, 2020 •
edited
Loading

The key commands issues still exist when I checked with Chrome on MacOS. I am assigning this bug to @jongund and @smhigley @sh0ji in case they can review and fix the problem. @jongund and @smhigley @sh0ji please feel free to unassign the issue to yourself if you are not available. ;-)

@a11ydoer a11ydoer assigned jongund, smhigley and sh0ji and unassigned jongund Feb 22, 2020
@smhigley
Copy link
Contributor

Does this work in any browser? I don't see any code to handle it, so I'd be a bit surprised if it did 😄.

@charmarkk
Copy link
Contributor

charmarkk commented Feb 24, 2020 •
edited
Loading

@smhigley it appears to work without fault in Firefox on Windows. 🤷‍♂

@JAWS-test
Copy link

JAWS-test commented Feb 24, 2020 •
edited
Loading

it appears to work without fault in Firefox on Windows

On my computer they do not work in Chrome and Firefox under Windows. But these access keys are only marked as optional.

@charmarkk
Copy link
Contributor

charmarkk commented Feb 24, 2020 •
edited
Loading

JAWS-test said

On my computer they do not work in Chrome and Firefox under Windows. But these access keys are only marked as optional.`

And so the plot thickens - good to know, thanks for that!

@smhigley
Copy link
Contributor

@charmarkk you're talking about the shift + arrows/home/end and control + A, right? That doesn't work for me in any browser in Windows, including Firefox (which is my main browser) 😄.

I think the plot actually thins -- there is no script to implement those keys, so they don't work anywhere 😂

@carmacleod
Copy link
Contributor

carmacleod commented Feb 24, 2020 •
edited
Loading

FF 73.0.1 and Chrome 80.0.3987.116 on Windows 10, Example 2 does not work as advertised in the Multiple selection keys supported in example 2 table (except for space key).

@charmarkk
Copy link
Contributor

@smhigley @carmacleod you're correct - my poor brain this Monday morning. Those keys indeed do not work as written. Thank you~

@smhigley
Copy link
Contributor

I'm working on an implementation now 👍

@smhigley smhigley mentioned this issue Feb 24, 2020
Merged
4 tasks
mcking65 added a commit that referenced this issue Mar 31, 2020
@smhigley @mcking65 @carmacleod
Listboxes with Rearrangeable Options: Add keyboard commands for multi…
f84febc 
…ple selection (pull #1344)

Resolves issue #919 by adding the following commands for selecting options:
- Shift + arrow keys
- Control + Shift + home and end
- Control + A, command-a on macOS
- Shift + Click

Adds regression tests for the commands.

Co-authored-by: Matt King <a11yThinker@gmail.com>
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
michael-n-cooper pushed a commit that referenced this issue Mar 31, 2020
@mcking65 @carmacleod
Generated by TRAVIS-CI f84febc
8db3085 
Listboxes with Rearrangeable Options: Add keyboard commands for multiple selection (pull #1344)

Resolves issue #919 by adding the following commands for selecting options:
- Shift + arrow keys
- Control + Shift + home and end
- Control + A, command-a on macOS
- Shift + Click

Adds regression tests for the commands.

Co-authored-by: Matt King <a11yThinker@gmail.com>
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
carmacleod added a commit to carmacleod/aria-practices that referenced this issue Mar 31, 2020
@smhigley @mcking65 @carmacleod
Listboxes with Rearrangeable Options: Add keyboard commands for multi…
a4b2258 
…ple selection (pull w3c#1344)

Resolves issue w3c#919 by adding the following commands for selecting options:
- Shift + arrow keys
- Control + Shift + home and end
- Control + A, command-a on macOS
- Shift + Click

Adds regression tests for the commands.

Co-authored-by: Matt King <a11yThinker@gmail.com>
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jongund jongund

@smhigley smhigley

@sh0ji sh0ji

Labels
bug Code defects; not for inaccurate prose Example Page Related to a page containing an example implementation of a pattern
Projects
Listbox Pattern and Examples Development Project
Status: Complete
Milestone
1.2 Release 1