Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for aria-level attribute #1109

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

spectranaut
Copy link
Contributor

@spectranaut spectranaut commented Jul 22, 2019

Initial draft of content for issue #259 to provide a guidance section on aria-level.

Might still need some discussion related to this open issue on ARIA: w3c/aria#915

Preview link

View the content in compare branch using rawGitHack


Preview | Diff

@zcorpan
Copy link
Member

zcorpan commented Aug 30, 2019

I don't think this section needs to be blocked on w3c/aria#915 - we can update APG if necessary when ARIA changes, and have an open issue for APG to track that issue: #1156

As far as I can tell, the next step for this PR is review.

@zcorpan zcorpan changed the title Initial draft of guidelines for aria-level attribute Guidelines for aria-level attribute Aug 30, 2019
@zcorpan
Copy link
Member

zcorpan commented Oct 28, 2019

w3c/aria#915 has been resolved, and I've now updated this PR.

aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
@zcorpan zcorpan self-assigned this Oct 28, 2019
@zcorpan zcorpan force-pushed the issue259-aria-level-guidance branch from 1a7be3c to 038c41b Compare October 31, 2019 19:21
@zcorpan zcorpan self-requested a review October 31, 2019 19:21
@charmarkk
Copy link
Contributor

The layout of some of the code snippets seems a little wonky and it seems like they don't wrap. Should they/is that an issue of the preview?

Otherwise, looks good to me. 👌

@zcorpan
Copy link
Member

zcorpan commented Nov 2, 2019

That's a known bug of the diff preview.

aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • several instances of "header" need to change to "heading"
  • not sure whether it makes sense to create landmark regions in the "Definition of a Room" use cases?

@charmarkk
Copy link
Contributor

charmarkk commented Nov 4, 2019

@zcorpan said

That's a known bug of the diff preview.

I had thought as much, thanks for clearing that up friendo!

@zcorpan
Copy link
Member

zcorpan commented Nov 5, 2019

Thank you for the review, @carmacleod! I've addressed your comments.

I think you're right that the remediation use case example shouldn't add landmark regions.

Copy link
Contributor

@carmacleod carmacleod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jongund
Copy link
Contributor

jongund commented Nov 5, 2019

@mcking65 In section 8.2 for listitem role, wouldn't a better example be for lists that are partially rendered list do to size/length of the list and or bandwidth limitations of the device. This I believe this is one of the primary reason for other similar attributes like aria-posinset and aria-setsize to be included in ARIA.

@jongund
Copy link
Contributor

jongund commented Nov 5, 2019

@mcking65 In section 8.1 Heading Role, what if someone wants to use a aria-level value greater than 6? For example, in some type of document with a high level of nesting. Is that going to be allowed? If not we should state the allowed range i 1 to 6, if allowed there should be some type of guidance on values greater than 6.

aria-practices.html Outdated Show resolved Hide resolved
aria-practices.html Outdated Show resolved Hide resolved
@zcorpan zcorpan force-pushed the issue259-aria-level-guidance branch from d2b76bb to 7644cf5 Compare November 2, 2021 12:05
@zcorpan
Copy link
Member

zcorpan commented Nov 2, 2021

@mcking65 @jongund @a11ydoer thanks, addressed.

Copy link
Contributor

@jongund jongund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Draft guidance on aria-level
10 participants