-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guidelines for aria-level attribute #1109
base: main
Are you sure you want to change the base?
Conversation
I don't think this section needs to be blocked on w3c/aria#915 - we can update APG if necessary when ARIA changes, and have an open issue for APG to track that issue: #1156 As far as I can tell, the next step for this PR is review. |
w3c/aria#915 has been resolved, and I've now updated this PR. |
1a7be3c
to
038c41b
Compare
The layout of some of the code snippets seems a little wonky and it seems like they don't wrap. Should they/is that an issue of the preview? Otherwise, looks good to me. 👌 |
That's a known bug of the diff preview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- several instances of "header" need to change to "heading"
- not sure whether it makes sense to create landmark regions in the "Definition of a Room" use cases?
@zcorpan said
I had thought as much, thanks for clearing that up friendo! |
Thank you for the review, @carmacleod! I've addressed your comments. I think you're right that the remediation use case example shouldn't add landmark regions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@mcking65 In section 8.2 for listitem role, wouldn't a better example be for lists that are partially rendered list do to size/length of the list and or bandwidth limitations of the device. This I believe this is one of the primary reason for other similar attributes like aria-posinset and aria-setsize to be included in ARIA. |
@mcking65 In section 8.1 Heading Role, what if someone wants to use a aria-level value greater than 6? For example, in some type of document with a high level of nesting. Is that going to be allowed? If not we should state the allowed range i 1 to 6, if allowed there should be some type of guidance on values greater than 6. |
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Co-Authored-By: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
Co-authored-by: Carolyn MacLeod <Carolyn_MacLeod@ca.ibm.com>
d2b76bb
to
7644cf5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Initial draft of content for issue #259 to provide a guidance section on aria-level.
Might still need some discussion related to this open issue on ARIA: w3c/aria#915
Preview link
View the content in compare branch using rawGitHack
Preview | Diff