Add meter design pattern #1189
Add meter design pattern #1189
Conversation
| @@ -294,7 +294,7 @@ <h4>Example</h4> | |||
|
|
|||
| <section class="notoc"> | |||
| <h4>Keyboard Interaction</h4> | |||
| <p>An alert (WAI-ARIA live region) does not require any keyboard interaction.</p> | |||
| <p>Not applicable.</p> | |||
aria-practices.html
Outdated
| <section class="widget" id="meter"> | ||
| <h3>Meter</h3> | ||
| <p> | ||
| A <a class="role-reference" href="#meter">meter</a> allows authors to define a value within a known range. The minimum and maximum limits of the range must be defined numerically, and the value should be a number within the range. |
There was a problem hiding this comment.
I really like this definition, nice work!
aria-practices.html
Outdated
| A <a class="role-reference" href="#meter">meter</a> allows authors to define a value within a known range. The minimum and maximum limits of the range must be defined numerically, and the value should be a number within the range. | ||
| </p> | ||
| <p> | ||
| Meter examples could include current battery percentage, or a car's fuel level. A <code>meter</code> could not be used to represent a value like the current world population, since there is no meaningful maximum limit. |
There was a problem hiding this comment.
Meter examples could include current battery percentage, or a car's fuel level
Propose to change this to:
Meter example include a device’s current batter percentage and a car’s fuel level.
A
metercould not be used to
Propose we change to either:
A
metercannot be used to…
…or…
A
metershould not be used to…
I think the first one is a little more strict and to the point. But the second one reads a little bit friendlier (and is more consistent with other text). Thoughts?
There was a problem hiding this comment.
I like should, friendly sounds like a good approach :)
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<carmacleod> TOPIC: Meter pattern and example<carmacleod> github: Meter pattern and example <carmacleod> github: https://github.com//pull/1189 <carmacleod> jemma: consider changing color as meter value gets closer to 100%? <carmacleod> sarah: I can change the styling for this <carmacleod> jemma: should we wait until ARIA 1.3 for this? <carmacleod> mck: jemma is adding a review checklist to this <carmacleod> siri: I don't like the animation - there's no pause/play button <jamesn> q+ <carmacleod> james: Windows Task Manager allows pausing <carmacleod> mck: should we add a pause button? <carmacleod> group: yes <carmacleod> sarah: I'll add a pause button when I am adding the color |
mcking65
force-pushed
the
979-meter-pattern
branch
from
abcea30
to
4e260d0
Compare
|
@mcking65 thanks for all your suggestions! I updated the PR to include them 👍 |
|
@carmacleod wrote:
Per discussion in today's meeting, changed this in commit 9525fea. |
Initial draft of a meter pattern (the example implementation is tracked separately in #1105).
Resolves #979
Preview | Diff