Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs pattern: Add aria-orientation reference to keyboard note #1193

Merged
merged 4 commits into from
Nov 11, 2019
Merged

Tabs pattern: Add aria-orientation reference to keyboard note #1193

merged 4 commits into from
Nov 11, 2019

Conversation

aardrian
Copy link
Contributor

@aardrian aardrian commented Oct 3, 2019 •
edited by pr-preview bot
Loading

Addresses concerns raised in #976 .

Preview | Diff

ZoeBijl
ZoeBijl reviewed Oct 7, 2019
View reviewed changes
aria-practices.html Outdated Show resolved Hide resolved
@ZoeBijl ZoeBijl requested a review from mcking65 October 7, 2019 17:14
mcking65
mcking65 approved these changes Nov 11, 2019
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

My only concern is that merging this will make the tabs pattern inconsistent with other patterns that include aria-orientation. I'm OK with merging this and addressing those in subsequent PRs though.

@mcking65 mcking65 changed the title Added attribute reference into Tab note Tabs pattern: Add aria-orientation reference to keyboard note Nov 11, 2019
@mcking65 mcking65 merged commit 2b1c5b1 into w3c:master Nov 11, 2019
@ZoeBijl
Copy link
Contributor

ZoeBijl commented Nov 11, 2019

My only concern is that merging this will make the tabs pattern inconsistent with other patterns that include aria-orientation.

Why are they now inconsistent @mcking65?

@aardrian
Copy link
Contributor Author

@ZoeBijl @mcking65

My only concern is that merging this will make the tabs pattern inconsistent with other patterns that include aria-orientation.

Why are they now inconsistent @mcking65?

No other pattern currently on APG uses aria-orientation in its examples, 6 reference it in their overview. Only menu and toolbar have similar language and I am happy to make a PR for those. More detail and probably a good place to continue the discussion at #976 (comment).

@Clemens-git76 Clemens-git76 mentioned this pull request Apr 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

@ZoeBijl ZoeBijl ZoeBijl approved these changes

@jnurthen jnurthen jnurthen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aardrian @ZoeBijl @jnurthen @mcking65