Infrastructure: Codepen button should show only when resources loaded #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nschonni
reviewed
Sep 25, 2020
examples/js/examples.js
Outdated
| @@ -378,32 +380,28 @@ function addOpenInCodePenForm (exampleIndex, exampleHeaderId, exampleCodeId, exa | |||
| totalFetchedFiles++; | |||
| } | |||
| else { | |||
| hideButton(buttonId, "Could not load resource: " + href); | |||
| console.log("Not showing 'Open in Codepen' button. Could not load resource: " + href); | |||
There was a problem hiding this comment.
Does it make sense to warn/error for these?
Suggested change
| console.log("Not showing 'Open in Codepen' button. Could not load resource: " + href); | |
| console.warn("Not showing 'Open in Codepen' button. Could not load resource: " + href); |
There was a problem hiding this comment.
makes sense! pushed commit for switch.
|
@smhigley friendly ping when you get time |
Regression test coverage:Examples without any regression tests:
Examples missing some regression tests:
Example pages with Keyboard or Attribute table rows that do not have data-test-ids:
SUMMARY:55 example pages found. ERROR - missing tests: Please write missing tests for this report to pass. |
|
Thank you @smhigley and @carmacleod ... will merge! |
mcking65
added
enhancement
mcking65
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a good point @smhigley to show the button after the resources have been loaded instead of hiding it if they don't! :)
I didn't implement the promise array because XMLHttpRequest.send doesn't return a promise but that it's true that would have been much cleaner.