-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sortable table example #2046
Conversation
…e sort button action information
As a screen reader user, I find the button descriptions make the state of the table harder to understand. You have to listen very closely or you might think that the columns are are already sorted in the way the button description describes. I am not convinced we need descriptions. I wonder what other screen reader users think? If there were descriptions, I'd rather have it be clearly distinguishable from sort state, perhaps "Sorts by COLUMN_NAME" and leave out the directionality of the action. The sort direction is conveyed after activation. |
@mcking65 |
…hat are sortable, but not the currently sorted column.
Code review completed and LGTM! Have you been able to take a look at Matt's other requested changes @jongund? |
…aria-sort attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are very close to ready to ship. couple of questions left.
examples/table/sortable-table.html
Outdated
<h2>Accessibility Features</h2> | ||
<ul> | ||
<li> | ||
HTML table markup is used to create the rows, caption, and to identify the column headers for the data cells. The use of HTML supports the ARIA principle of using native element semantics whenever possible.<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HTML table markup is used to create the rows, caption, and to identify the column headers for the data cells. The use of HTML supports the ARIA principle of using native element semantics whenever possible.<br/>
I don't think we need to say this at all. As we add more and more HTML examples, saying we are using more HTML and less ARIA will be increasingly common and saying this over and over won't add value. Would you be OK with removing thisitem from the list?
examples/table/sortable-table.html
Outdated
<tr data-test-id="span-aria-hidden"> | ||
<td></td> | ||
<th scope="row"><code>aria-hidden="true"</code></th> | ||
<td><code>svg</code></td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be span instead of svg?
…TABLE markup and chnaged SVG to SPAN for aria-hidden
@mcking65 I made update to the example option description based on your feedback, removed the section on using HTML table markup and changes |
@nschonni HTML linting problem with files unrelated to this pull request. Not sure how to "fix" this issues, should probably be a separate pull request and not fixed in this one. |
Yes, it looks like the issues are related to #2055 landing, not this one |
@jongund the linting issue is now fixed and green here again |
I needed an example of a sortable table for someone at Illinois and thought I would propose it as an example for the APG.
Preview Link
Preview | Diff