-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About Page: Convert to an About section overview that links to several new pages within the about APG section #2558
Conversation
…rn at end of file name
…lass from H2 elements
All the content looks good on my end - just deleted some unnecessary spaces! 🚀 |
Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my feedback!
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Subtopic: About page ready for review - pull request 2558<jugglinmike> github: https://github.com//pull/2558 <jugglinmike> Matt_King: Just before this meeting, I added a link to the Netlify preview <jugglinmike> Matt_King: https://deploy-preview-207--aria-practices.netlify.app/aria/apg/about/ <jugglinmike> Andrea: At first glance, this looks good, visually <jugglinmike> Matt_King: Among other things, we want to make sure reflow works correctly and that color contrast is acceptable. <jugglinmike> Matt_King: The one thing that's different here is that we didn't use a "card" view for the "About" page. That was intentional (because we're not going to come up with graphics for each section) <jugglinmike> Alex_Flenniken: That's right, Isaac Durazo didn't create icons or other graphics for each of these <jugglinmike> Matt_King: Yeah, that's fine. We don't want to have to commit to distinct graphics for each of these things. Maybe we can in the future, if we want to spice it up... <jugglinmike> Matt_King: I wonder if we want to use some generic icons in the future--if that would help. But I don't know what our visual library is like <jugglinmike> Matt_King: if that all looks good to you, Andrea, then if you can submit a "GitHub Review" in the GitHub interface, that would be great <jugglinmike> (the group worked through a confusing part of the GitHub.com user interface for code review) |
@alflennik, my latest commits are not showing up in w3c/wai-aria-practices#207, so the preview is not up-to-date. |
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Subtopic: About page ready for review - pull request 2558<jugglinmike> github: https://github.com//pull/2558 <jugglinmike> Matt_King: I'd like to merge this <jugglinmike> Matt_King: I've received feedback from a few people on it <jugglinmike> Matt_King: Last night, I made a few changes based on feedback from John_Gunderson <jugglinmike> Matt_King: I had some difficulty--I made changes to the branch, but they weren't showing up in the preview <jugglinmike> Alex_Flenniken: That's due to how I created the preview for you. It's using Git Submodules in a way that prevents automatic updates. I can manually update the submodule for you <jugglinmike> Matt_King: That works <jugglinmike> Matt_King: I'd like to merge it in time to include it for the April 11th update <jugglinmike> Matt_King: I'd also appreciate a review from jamesn <jugglinmike> jamesn: So, the sections named "Introduction" and "ARIA Basics"? <jugglinmike> Matt_King: Yup, those are the two new sections. The other text could probably use some work as well, but it is wholesale copied from elsewhere on the site--it's what we've already published <jugglinmike> Matt_King: we'll skip the other items for this topic in the agenda) |
@mcking65 I've updated the existing preview link with the latest changes. |
Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
Could you please update the preview again? I just addressed the unresolved feedback and fixed a sentence where I made a rather embarrassing editorial blunder. |
@mcking65 okay, it's updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Content looks good. I liked the conciseness of role, properties and state in "aria basics" page and the table of "How the APG is organized" in "about page".
@mcking65 @alflennik The review is done. Thanks so much for great work. |
@jnurthen also reviewed this and he said via email that he did not see any issues. We are ready to publish. |
Implements #2423.
Preview of new About section
WAI Preview Link failed to build on 'Update site files' step. (Last tried on Wed, 05 Apr 2023 02:40:13 GMT).