-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tablist Examples: Improve support for magnification #2625
Conversation
…to support screen magnification
@mcking65 |
@mcking65 |
@jongund @mcking65 tracking in #2636 and filed a temporary fix in #2640 which is pinning the node version back to |
@mcking65 |
@mcking65 |
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Subtopic: PR 2625 - Tablist Examples: Improve support for magnification by jongund<jugglinmike> github: https://github.com//pull/2625 <jugglinmike> Matt_King: jongund isn't here today, but I'd like to assign some folks to review, if possible <jugglinmike> Andrea: I can help out! <jugglinmike> Andrea: I can do visual review and accessibility review <jugglinmike> Matt_King: This is a really narrowly-scoped set of changes to CSS <jugglinmike> Matt_King: I don't know if there's much of a code review to be done here <jugglinmike> Alex_Flenniken: I can do the code review <jugglinmike> (Matt_King updates the review checklist) <jugglinmike> (Matt_King adds Andrea's account to the GitHub Team named "aria contributors" in order to authorize review) <jugglinmike> Matt_King: I think that's all we can do for pull requests without jongund present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, and I confirmed that it works by comparing the current version with the updated version - for both examples I verified that the current version is causing horizontal scrollbars and that the updated version fixes the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial review complete; looks good.
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Subtopic: PR 2625 - Tablist Examples: Improve support for magnification by jongund<jugglinmike> github: https://github.com//pull/2625 <jugglinmike> Andrea_: I think this just requires a final accessibility review from me <jugglinmike> Andrea_: I have to set up some ATs, but I expect to finish that today <jugglinmike> Matt_King: Looks like you have some suggested edits in here <jugglinmike> Andrea_: Yeah, a couple of typos <jugglinmike> Matt_King: looks like Alex_Flenniken is also assigned to this, too <jugglinmike> Matt_King: We may be able to include this for April 11, too. That'd be great |
Other than a few typos - a11y check has been done and approved! |
@alflennik are the above changes something I can commit or should someone else? Other than those fixes, I'd like to approve. thank you! :) |
@andreancardona oh good question, I'm not sure, I've seen different kinds of approaches in past APG PRs - I've seen Matt commit editorial changes directly to PRs in the past, but I've also seen the person who opened the PR being responsible for making recommended changes. @jongund I'm curious whether you prefer for Andrea to commit spelling changes directly to the PR or for you to be responsible for that. |
"insure" > "ensure" Co-authored-by: Andrea N. Cardona <cardona.n.andrea@gmail.com>
@andreancardona wrote:
If fixing an obvious typo, feel free to either commit or use the suggestion feature as you did. If changing wording, please use the suggestion feature. Thank you very very much for the thorough and detailed review!! |
Resolves #2284 and #2257 with the following changes:
Preview Updated Tablist Examples
Review checklist
WAI Preview Link (Last built on Mon, 10 Apr 2023 06:55:59 GMT).