Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed Example: Move display of example from separate page into standard APG example page #2775

Merged
merged 29 commits into from
May 22, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
76aea70
Move feed example inside the page
ariellalgilmore Aug 10, 2023
86d965b
missing closing div
ariellalgilmore Aug 10, 2023
6bd013d
fix feed modal in mobile
ariellalgilmore Aug 10, 2023
bb2bee4
update tests
ariellalgilmore Aug 10, 2023
d515772
update feed example to use iframe
ariellalgilmore Aug 28, 2023
76492cb
fix linting issues
ariellalgilmore Aug 28, 2023
97e0565
fix feed tests
ariellalgilmore Aug 28, 2023
8869202
fix iframe reference
ariellalgilmore Aug 29, 2023
afc6dec
fix: update feed
andreancardona Aug 30, 2023
be5f596
fix delay time call
ariellalgilmore Aug 31, 2023
d060cdd
fix iframe src
ariellalgilmore Aug 31, 2023
a6c4fb7
update to example options
ariellalgilmore Sep 26, 2023
0edc38e
Update feed.html
andreancardona Sep 28, 2023
9239b1b
Make some editorial revisions to the introduction and remove fieldset…
mcking65 Oct 1, 2023
9d07514
Move label and further refine description of loadin delay
mcking65 Oct 1, 2023
788766d
Trigger the generation of a "preview" deployment
jugglinmike Oct 2, 2023
e731b07
Empty commit to trigger rebuild
howard-e Nov 1, 2023
f0aaf77
add button after feed
ariellalgilmore Dec 19, 2023
894dfa1
fix(feed): test update
ariellalgilmore Jan 8, 2024
b689ae4
fix(feed): color contrast
ariellalgilmore Jan 16, 2024
54fcb8e
fix(feed): bookmark button size
ariellalgilmore Jan 16, 2024
3c4fa26
Merge remote-tracking branch 'upstream/main' into issue-2747-feed-exa…
ariellalgilmore Jan 16, 2024
50f7a04
Merge remote-tracking branch 'origin/main' into issue-2747-feed-example
mcking65 Apr 7, 2024
2574099
update coverage & update ctrl-end to terms-of-use
ariellalgilmore Apr 30, 2024
fe7f062
Merge remote-tracking branch 'origin/main' into issue-2747-feed-example
mcking65 May 5, 2024
b83b2fb
Merge branch 'issue-2747-feed-example' of https://github.com/w3c/aria…
mcking65 May 5, 2024
dc06d9b
revise intro
mcking65 May 21, 2024
2e3b159
Correction to ctrl+home documentation
mcking65 May 21, 2024
f8307ad
Make link text match new example page title
mcking65 May 21, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion content/patterns/feed/examples/feed.html
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,8 @@ <h2>About This Example</h2>
<h2 id="ex_label">Example</h2>
<div role="separator" id="ex_start_sep" aria-labelledby="ex_start_sep ex_label" aria-label="Start of"></div>
<div id="ex1">
<p>The example feed experience is presented on a separate <a href="feed-display.html">feed display page.</a></p>
<p>The example feed experience below is presented in an iframe in order not to obstruct from the rest of the content of the page. </p>
<iframe id="feed_frame" src="./feed-display.html" height="500" title="Feed example" style="width: 100%"></iframe>
a11ydoer marked this conversation as resolved.
Show resolved Hide resolved
</div>
<div role="separator" id="ex_end_sep" aria-labelledby="ex_end_sep ex_label" aria-label="End of"></div>
</section>
Expand Down
Binary file removed content/patterns/feed/examples/imgs/rating-1.png
Binary file not shown.
Binary file removed content/patterns/feed/examples/imgs/rating-2.png
Binary file not shown.
Binary file removed content/patterns/feed/examples/imgs/rating-3.png
Binary file not shown.
Binary file removed content/patterns/feed/examples/imgs/rating-4.png
Binary file not shown.
Binary file removed content/patterns/feed/examples/imgs/rating-5.png
Binary file not shown.
14 changes: 2 additions & 12 deletions test/tests/feed_feed.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const assertAriaDescribedby = require('../util/assertAriaDescribedby');
const exampleFile = 'content/patterns/feed/examples/feed.html';

const ex = {
feedLinkSelector: '#ex1 a',
frameID: 'feed_frame',
feedSelector: '[role="feed"]',
articleSelector: '[role="article"]',
timeToLoad10Articles: 2500,
Expand All @@ -19,17 +19,7 @@ const ex = {
};

const navigateToFeed = async function (t) {
await t.context.session.findElement(By.css(ex.feedLinkSelector)).click();

return t.context.session.wait(
() => {
return t.context.session.getCurrentUrl().then((url) => {
return url != t.context.url;
});
},
t.context.waitTime,
'The feed url did not load after clicking: ' + ex.feedLinkSelector
);
await t.context.session.switchTo().frame(ex.frameID);
};

const waitForArticlesToLoad = async function (t) {
Expand Down
Loading