Menu Button Pattern: Change to specify aria-expanded="false" when menu is not visible #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 3, 2023
|
The task force agreed to move forward with this change in the October 3, 2023 meeting. This PR revises the menu button pattern and the PR that resolves #2834 will make the example code match the revised pattern guidance. |
a11ydoer
approved these changes
Oct 10, 2023
| @@ -56,8 +56,7 @@ <h2>WAI-ARIA Roles, States, and Properties</h2> | |||
| <li>The element with role <code>button</code> has <a href="#aria-haspopup" class="property-reference">aria-haspopup</a> set to either <code>menu</code> or <code>true</code>.</li> | |||
| <li> | |||
| When the menu is displayed, the element with role <code>button</code> has <a href="#aria-expanded" class="state-reference">aria-expanded</a> set to <code>true</code>. | |||
| When the menu is hidden, it is recommended that <code>aria-expanded</code> is not present. | |||
| If <code>aria-expanded</code> is specified when the menu is hidden, it is set to <code>false</code>. | |||
| When the menu is hidden, <code>aria-expanded</code> is set to <code>false</code>. | |||
There was a problem hiding this comment.
This editorial change makes the point concise and clear. Great!
|
Regarding test review: below test id are missing.
|
|
Adding this change to #2839. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #697, remove the recommendation that aria-expanded be removed when the controlled menu is hidden. Instead, specify that aria-expanded should be set to false. See also #2808.
Preview Link
Preview revised roles, states, and properties section of menu button pattern
Review checklist
Reviewers: To learn what needs to be covered by each review, Follow the link for the type of review to which you are assigned.
WAI Preview Link (Last built on Mon, 02 Oct 2023 01:42:57 GMT).