Modal Dialog example: Correct JSDoc warning #3083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The ARIA Authoring Practices (APG) Task Force just discussed The full IRC log of that discussion<jugglinmike> Topic: Simple JSDoc PR for modal dialog<jugglinmike> github: https://github.com//pull/3083 <jugglinmike> Matt_King: We just need someone to volunteer to review <jugglinmike> Adam_Page: I'll take it <jugglinmike> Jem: Thank you! I'll assign you |
adampage
approved these changes
Aug 27, 2024
mcking65
changed the title
mcking65
added
the
Code Quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this on another PR, so made the updated according to the rule https://github.com/gajus/eslint-plugin-jsdoc/blob/main/docs/rules/require-returns-check.md#user-content-require-returns-check-passing-examples
WAI Preview Link (Last built on Wed, 31 Jul 2024 19:29:54 GMT).