Issue #158 Add Optional Keyboard Commands to Accordion Example #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gerardkcohen, thank you! This looks excellent. I really like the refactoring, especially the use of data attribs to control the expand/collapsing behaviors and the css icons. On windows, Ctrl+pageUp/Down are not working for me; the browser is grabbing them. Also it looks like you are not filtering out modifier keys when not applicable, e.g., ctrl+home/end do same as home/end. Should be ignoring all modifiers on those. Nonetheless, I don't want to keep this out of the publication we are working on for this week, so I am merging and opening a separate review issue to collect this and other feedback. |
mcking65
added a commit
that referenced
this pull request
Jun 18, 2017
Given the significance of the updates made in pull request #397 by @gerardkcohen, This commit adds a link to a review issue to gather feedback on the updates and collect issues.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the following (optional) keyboard commands based on issue #158:
Up/ Down: Cycle focus through accordion toggle controls/ headings
Home/ End: Focus first/ last accordion toggle control/ heading
Control + Page Up/ Down: Move focus from accordion panel to accordion heading, and then cycle through headings.
Also refactored JS and CSS to be simpler to understand.