Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update keyboard shortcuts for listbox #479

Merged
merged 3 commits into from
Oct 18, 2017
Merged

Conversation

tatermelon
Copy link
Contributor

  • Updated Add and Important buttons to be triggered by Enter instead of Delete
  • Added Alt up/down shortcuts for shifting items in Important list

@mcking65
Copy link
Contributor

@tatermelon,

I am experiencing a strange bug. I tested in Firefox. Here are repro steps:

  1. Tab to available upgrades listbox.
  2. Press End key.
  3. Press space to select, up arrow and press select to select 2nd to last item as well.
  4. Press enter to add.

Result: Focus jumps to chosen upgrades. Pressing back-tab twice returns focus to chosen upgrades. Can not get to available upgrades.

Expected result: The two selected items are added to chosen upgrades and focus remains in available upgrades.

The bug occurs if two or more consecutive items are selected and one of the selected items is the last item.

@mcking65
Copy link
Contributor

@tatermelon, one other question ... are there any tooltips or anything like that on the toolbar buttons that can reveal the key shortcuts to sighted users?

@mcking65
Copy link
Contributor

It's working great now!! Merging.

@mcking65 mcking65 merged commit 43f88c7 into w3c:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants