Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we be using 'section' to wrap roles, states, and properties #4

Closed
halindrome opened this issue Apr 30, 2014 · 2 comments · Fixed by #5
Closed

Should we be using 'section' to wrap roles, states, and properties #4

halindrome opened this issue Apr 30, 2014 · 2 comments · Fixed by #5
Labels
question

Comments

@halindrome
Copy link
Contributor

When converting the document to ReSpec, I placed these items in sections instead of divs. This means that they show up in the table of contents. Should they? If not, we should convert them all back to divs.
halindrome added a commit to halindrome/aria that referenced this issue May 2, 2014
@halindrome
Changed section elements on roles, states, and properties to divs
3f0825b 
(closes w3c#4)
@cookiecrook
Copy link
Contributor

I like your change, yes.

@halindrome
Copy link
Contributor Author

I think I can just create a pull request. Let me try.

This was referenced May 21, 2014
Closed
Merged
mattgarrish pushed a commit that referenced this issue Mar 8, 2015
Merge pull request #4 from w3c/master
a5870f3 
Merge pull request #17 from mattgarrish/master
@DavidMacDonald DavidMacDonald mentioned this issue Jun 26, 2017
Closed
@giacomo-petri giacomo-petri mentioned this issue Aug 30, 2023
Closed
pkra pushed a commit that referenced this issue May 20, 2024
@mattgarrish
fix "principle" typo. closes issue #4
78da9b3
pkra pushed a commit that referenced this issue May 20, 2024
@iherman
Merge branch 'master' of https://github.com/w3c/dpub-aria
121af3c 
* 'master' of https://github.com/w3c/dpub-aria:
  swap/remove problematic roles in doc-glossary example
  allow name from contents for doc-subtitle as reported in issue #6
  update doc-pullquote superclass to section to match AAM mapping as reported in issue #7
  fixes the typo in the example markup reported in issue #3
  fix "principle" typo. closes issue #4
  fixes typos reported in PR #1
pkra pushed a commit that referenced this issue May 20, 2024
@mattgarrish
Merge pull request #4 from w3c/dpub-aam
68afbfe 
Add mappings for pagefooter/pageheader
pkra pushed a commit that referenced this issue May 21, 2024
@AmeliaBR
Editorial fixes
58aa5da 
Closes #4
pkra pushed a commit that referenced this issue May 21, 2024
respec cleanup (#4)
3c65a46 
* Acknowledgements include no longer recursive due to respec change

* respecConfig cleanup

from #1246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changed section elements on roles, states, and properties to divs halindrome/aria
2 participants
@cookiecrook @halindrome