Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IDL and enumerated attribute section #1611

Merged
merged 5 commits into from
Sep 17, 2021
Merged

Update IDL and enumerated attribute section #1611

merged 5 commits into from
Sep 17, 2021

Conversation

jnurthen
Copy link
Member

@jnurthen jnurthen commented Sep 3, 2021 •
edited by cookiecrook
Loading

fixes #1598

Preview | Diff

@jnurthen
Copy link
Member Author

jnurthen commented Sep 7, 2021

fixes #1598

cyns
cyns approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@cyns cyns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cyns cyns mentioned this pull request Sep 9, 2021
Closed
cookiecrook
cookiecrook approved these changes Sep 9, 2021
View reviewed changes
Copy link
Contributor

@cookiecrook cookiecrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Removed the whitespace-only diff b/c it seemed accidental.

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
scottaohara
scottaohara reviewed Sep 9, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
scottaohara
scottaohara reviewed Sep 9, 2021
View reviewed changes
index.html Outdated Show resolved Hide resolved
jnurthen and others added 3 commits September 9, 2021 11:01
@jnurthen @cookiecrook
Update index.html
d61f6fe 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@jnurthen @cookiecrook
Update index.html
fccd6e6 
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@jnurthen
fix review comment (closing </p>)
2acf5cd
jongund
jongund approved these changes Sep 15, 2021
View reviewed changes
Copy link
Contributor

@jongund jongund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jnurthen jnurthen merged commit 0d06a71 into main Sep 17, 2021
@jnurthen jnurthen mentioned this pull request Sep 17, 2021
Closed
jnurthen added a commit that referenced this pull request Sep 17, 2021
@jnurthen @cyns @cookiecrook
Update IDL and enumerated attribute section (#1611)
cd04b6a 
Co-authored-by: Cynthia Shelly <cyns@users.noreply.github.com>
Co-authored-by: James Craig <cookiecrook@users.noreply.github.com>
@jnurthen jnurthen mentioned this pull request Sep 23, 2021
Closed
@liamdebeasi liamdebeasi mentioned this pull request Oct 27, 2021
Closed
6 tasks
@joanmarie
Copy link
Contributor

crap. clicked on the wrong thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottaohara scottaohara scottaohara left review comments

@cyns cyns cyns approved these changes

@marcoscaceres marcoscaceres marcoscaceres left review comments

@jongund jongund jongund approved these changes

@cookiecrook cookiecrook cookiecrook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating ARIA 1.2 due to IDL implementations (exit and re-enter CR?)
7 participants
@jnurthen @joanmarie @cookiecrook @marcoscaceres @jongund @cyns @scottaohara