Shane save roles #24
Merged
Shane save roles #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the URL is referenced as aria.html?saveRoles then the system will open a save dialog and allow you to save the updated roleInfo.js file. This is necessary for child specifications, and should be saved into the script directory.
Also removed extra dialog from saveRoles behavior.
pkra
pushed a commit
that referenced
this pull request
May 20, 2024
pkra
pushed a commit
that referenced
this pull request
May 20, 2024
Editorial: "controller-for" is not a good example for semantic significance #24
pkra
pushed a commit
that referenced
this pull request
May 21, 2024
This commit performs the following, for consistency with HTML AAM: - Move the [wai-aria-1.1] rows at the top. - Explicitly state "No corresponding role".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple change to the base aria.js script that will allow it to save a snapshot of the roles, states, and properties so that specs such as dpub can easily incorporate references.
I am planning to merge it since the change is non-intrusive unless you use the special ?saveRoles parameter on the aria.html URL.