find-specs broken - no way to extract stage 3 TC39 proposals #1031
Comments
|
switching to puppeteer would allow to revisit the use of spec-generator we took in #944 |
tidoust
added a commit
that referenced
this issue
Aug 28, 2023
Puppeteer is more heavy-weight but JSDOM cannot easily load specs and GitHub pages. This update: - fixes the find-specs script (#1031) - removes the dependency on the spec-generator service
tidoust
added a commit
that referenced
this issue
Aug 28, 2023
Puppeteer is more heavy-weight but JSDOM cannot easily load specs and GitHub pages. This update: - fixes the find-specs script (#1031) - removes the dependency on the spec-generator service
|
Switched to Puppeteer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
TC39 stage 3 proposals are extracted from a rendered version of a
README.mdfile fetched from GitHub with JSDOM. GitHub now seems to be making an extensive use of React to load the contents of the page dynamically, and this does not seem to work well with JSDOM. The find-specs script fails accordingly as it cannot find the<table>elements.We could perhaps to switch to Puppeteer. Or retrieve the markdown itself and parse it or render it ourselves with some dedicated library.
(Also note the default branch name was renamed to
mainbut the URL of the README file is not the cause of the issue).The text was updated successfully, but these errors were encountered: