-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MIME types from mandatory data list that are not supported by all browsers. #155
Conversation
I would prefer to only land the MUST lists as those seem to have agreement. Optional support for types doesn't seem like a great thing to allow and wasn't discussed in the referenced issue. |
@annevk |
That's not entirely clear to me. For the types that only some browser supports the right answer might well be that the browser removes support for that type. If all browsers are to implement it, it shouldn't be optional. This isn't a guide for web developers, this is what we want browsers to converge on. |
@annevk OK, removed the optional types. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks to be in line with the discussion, however, shouldn't JPEG and GIF be supported as well?
This would benefit from at least one other set of eyes.
Added @mkruisselbrink to the review as well. |
I think in Chromium, we convert these into PNG and write it to the clipboard. @a-sully made changes in this space so maybe he can confirm the behavior here. |
I'm not familiar with the details of how non-PNG images are written to the clipboard, but I can confirm that PNG is the only image format supported on the Chromium clipboard. That being said, JPEGs and GIFs are typically copied to and read from the clipboard as files using the |
At least on Windows, I don't see Chromium reading GIF, JPEGs files. In this method, I see only PNG and BMP formats being read from the clipboard. However, on Windows, when I copy a GIF file, the location of the file is present in the clipboard under |
They're read as files using the I realized I wasn't very clear on this above. Yes, you are correct. Reading files is not yet supported for the Async Clipboard API, though we'd like to at some point (see the tracking bug). |
Thank you for confirming! Since Safari already supports |
Gentle ping.. I'd like to merge this PR and work on improving other parts of the spec. |
Adding @mbrodesser as well. Gentle ping for review.... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, given the previous discussion at w3c/editing#305.
Only the title of the PR should be adapted to reflect the current change.
Adding @whsieh as well for sign-off |
Looks good to me! |
…all browsers. (#155) * Add mandatory and optional data types list. * Add optional types separately. * Remove optional data type.
Closes w3c/editing#305
For normative changes, the following tasks have been completed:
Implementation commitment:
Preview | Diff