Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define "valid" #35

Closed
2 tasks
jyasskin opened this issue Sep 22, 2023 · 3 comments
Closed
2 tasks

Define "valid" #35

jyasskin opened this issue Sep 22, 2023 · 3 comments
Assignees
Labels
editorial This item is editorial in nature. pr exists A Pull Request exists to address this issue.

Comments

@jyasskin
Copy link
Member

@msporny msporny added the editorial This item is editorial in nature. label Feb 25, 2024
@msporny msporny transferred this issue from w3c/vc-data-integrity Jun 21, 2024
@msporny msporny self-assigned this Jul 31, 2024
@selfissued
Copy link
Collaborator

I suggest changing "If controllerDocument is not a valid controller document" to "If controllerDocument does not conform to the requirements defined by this specification".

Likewise, I suggest changing "If verificationMethod is not a valid verification method" to "If verificationMethod does not conform to the requirements defined by this specification".

@msporny msporny added the ready for pr This issue is ready to have a pull request created for it. label Aug 14, 2024
@iherman
Copy link
Member

iherman commented Aug 14, 2024

The issue was discussed in a meeting on 2024-08-14

  • no resolutions were taken
View the transcript

4.6. Define "valid" (issue controller-document#35)

See github issue controller-document#35.

Manu Sporny: https://w3c.github.io/controller-document/#conformance.

Manu Sporny: Right, agreed with what you said, Brent, I think we already have this in the spec. We have a conformance section -- talks about conforming document, processor, etc. There may be some detail that I'm missing in some comment.

Brent Zundel: Would the fix then just be to fix the data integrity language to say "conforming"?

Joe Andrieu: +1 to say "conforming".

Manu Sporny: Yes.
… I moved this over to the controller document spec because the retrieve verification method algorithm is now in the controller document spec. The change needs to be made there now.
… What we should do is say "If the verification method is not a conforming verification method..." that will make it clear.
… What Mike said in here is correct. We can make this more clear, it's an editorial change, I think it's ready for PR. We just need to link to the conforming statements and make this really clear.

Brent Zundel: This is another one that is editorial and it's clear what to do so if they can help out Manu, that would be great.

Will Abramson: I can do this one.

@selfissued selfissued added pr exists A Pull Request exists to address this issue. and removed ready for pr This issue is ready to have a pull request created for it. labels Aug 29, 2024
@msporny
Copy link
Member

msporny commented Aug 29, 2024

PR #44 has been merged, closing.

@msporny msporny closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial This item is editorial in nature. pr exists A Pull Request exists to address this issue.
Projects
None yet
Development

No branches or pull requests

5 participants