Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[worklets] Fetching and invoking a worklet script which reports an exception #407

Closed
asajeffrey opened this issue May 12, 2017 · 3 comments

Comments

@asajeffrey
Copy link

The algorithm to fetch and invoke a worklet script (https://drafts.css-houdini.org/worklets/#fetch-and-invoke-a-worklet-script) will reject the promise if the fetch fails (step 3) but if running the module script (step 4) reports an exception, the promise will be resolved (step 5).

Should the promise be rejected if running the module script reports an exception?

asajeffrey pushed a commit to asajeffrey/servo that referenced this issue Jun 19, 2017
asajeffrey pushed a commit to asajeffrey/servo that referenced this issue Jun 20, 2017
asajeffrey pushed a commit to asajeffrey/servo that referenced this issue Jun 22, 2017
asajeffrey pushed a commit to asajeffrey/servo that referenced this issue Jun 27, 2017
@karlt
Copy link

karlt commented Sep 26, 2018

#509 (comment) advises that Chrome should reject the promise with the module script's error to rethrow.

@karlt
Copy link

karlt commented Aug 6, 2019

Oh, error to rethrow is determined during fetch (step 3), so that's not relevant to step 5, sorry.

@domenic
Copy link
Contributor

domenic commented Oct 16, 2020

I think this was fixed at some point in the past, and can be closed. https://html.spec.whatwg.org/multipage/worklets.html#dom-worklet-addmodule rejects the promise with the error-to-rethrow, and I copied that from the worklets spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants