-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-properties-values-api] @property vs setProperty #902
Comments
I'd prefer revisiting #880, fwiw. |
This is why I was surprised to see you announcing We need to nail down the semantics of Namely:
|
Hehe, I sent an Intent to Implement (behind and flag). It's basically a glorified "Hey guys, FYI, I'm experimenting with this". I wasn't going to go further than that without a sane spec, of course. 😄 I just wanted to get things moving. At least there is some activity on the GitHub side now. @tabatkins While that list is somewhat intimidating, I'm still more worried about this issue. Because of it, @emilio wants to reopen #880, and basically change the behavior to "never invalidate from any source". I was hoping you would have an opinion on this. |
Hmmmmmmmm. I think we need to think over this list to answer the question fully, tho. There are some stacked decisions here that we might be able to more fully unwind if we're revisiting decisions. To the point: if we give up on invalidation entirely (deferring all of it to computed-value time), then why don't we have the ability to unregister a property? It seems like we'd be free to allow it, then. (I'm pretty sure we chunked that because of invalidation, originally, if I recall correctly.) And if that's the case, then all the questions up above suddenly answer themselves: the I am quite interested in seeing |
Hmm ... unregistering also seems relatively unproblematic with the current state of things (though I may be missing something). Sure, it changes what's accepted by CSSOM/TypedOM, but why is that worse than the transition from not registered to registered in the first place?
Yeah, me too. There's a real chance (The current behavior is enabled in Chrome Beta at the moment, but now I'm leaning towards disabling it before it hits stable). |
I agree with pretty much everything y'all have said. Unregistration also doesn't seem extremely problematic. Giving up on typed om / setProperty invalidation is the easiest and simplest way to make this whole model make sense IMO. The only other question then is, I'd think, what happens when script-registered and style-registered properties clash. I think the easiest solution to that problem is saying that they're independent (that is, you can't |
For reference, here's the log with that decision: https://logs.csswg.org/irc.w3.org/houdini/2016-09-22/#e727846
It seems like it. 😐
That's an interesting proposal! This is #845, BTW. There is also #846, though that issue is probably not unique to |
It now looks as if the spec may need to change in a way that's very much backwards-incompatible (CSS.supports behavior could change) [1]. It definitely sucks, but releasing this now is too risky. [1] w3c/css-houdini-drafts#902 Bug: 641877 Change-Id: I321a112255d91b815ac050a242707dc12f184e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670208 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#671249}
It now looks as if the spec may need to change in a way that's very much backwards-incompatible (CSS.supports behavior could change) [1]. It definitely sucks, but releasing this now is too risky. [1] w3c/css-houdini-drafts#902 (cherry picked from commit 4d4157c) Bug: 641877 Change-Id: I321a112255d91b815ac050a242707dc12f184e4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670208 Reviewed-by: Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#671249} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1679702 Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/branch-heads/3809@{#626} Cr-Branched-From: d82dec1-refs/heads/master@{#665002}
* [css-properties-values-api] Generally ignore syntax in APIs. Resolves #902. * supports()
Given an
@property
rule in some stylesheet, how should the two-paramsetProperty()
/CSS.supports()
behave? They probably need to take into account the registration caused by the@property
rule, even if that registration has not yet been effectuated.Updating "style data" (as @emilio calls it in this comment) during
setProperty()
seems nasty.Do we revisit #880? Give up on
@property
? Accept the nastiness? Something else?cc @tabatkins
The text was updated successfully, but these errors were encountered: