Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Validated CSS" is not correct for some @​rules #182

Open
ylafon opened this issue Mar 16, 2018 · 2 comments
Open

"Validated CSS" is not correct for some @​rules #182

ylafon opened this issue Mar 16, 2018 · 2 comments

Comments

@ylafon
Copy link
Member

ylafon commented Mar 16, 2018

Like @media screen { }giving @media screen in the output, or improper { in the case of nested @​rules.

ylafon added a commit that referenced this issue Mar 16, 2018
…ayed

improperly. It is the responsability of the AtRule to determine if {} should
be displayed or not, See #182
@hannibal218bc
Copy link
Contributor

hannibal218bc commented Dec 21, 2019

Consider this example:

@media print {
    @page {size: a4}
    body {background: none}
 }

The validator will currently show:

@media print {}
@page {size: a4}
body {background: none}

Notice how the "@media print" is ended before the @page block and how the "body" rule is promoted to the global (unrestricted) level.

Is this also in the scope of this issue?

hannibal218bc added a commit to Handig-Eekhoorn/css-validator that referenced this issue Dec 22, 2019
@hannibal218bc
Copy link
Contributor

At https://github.com/Handig-Eekhoorn/css-validator/tree/heek-nested-blocks-fix-issue-182 is a first try to make Stylesheet and CssRuleList aware of nested CssRuleList blocks.
I've only added a List<CssRuleList> newGetRulesTree() to Stylesheet and List<ICssStyleRuleOrCssRuleList> getStyleRulesTree() to CssRuleList.

I have no idea what further needs to be done to also display the rule block tree on the validation output page.

RichardCox09 pushed a commit to Handig-Eekhoorn/css-validator that referenced this issue Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants