Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cssom-view] isVisible inert option #7274

Closed
josepharhar opened this issue May 12, 2022 · 4 comments
Closed

[cssom-view] isVisible inert option #7274

josepharhar opened this issue May 12, 2022 · 4 comments

Comments

@josepharhar
Copy link
Contributor

It was brought up here that the inert option of isVisible doesn't really have anything to do with visibility, so perhaps it should be removed from isVisible: https://drafts.csswg.org/cssom-view/#dom-isvisibleoptions-checkinert

cc @chrishtr @tabatkins @vmpstr @smaug----

@Loirooriol
Copy link
Contributor

It's a bit of a stretch, but in Blink inert is like aria-hidden for accessibility purposes. So it would be checking the visibility for users who use assistive technologies like screen readers? Though if we want that, it should probably check for both aria-hidden and inertness, not just the latter.

@vmpstr vmpstr added the Agenda+ label May 16, 2022
@vmpstr
Copy link
Member

vmpstr commented May 16, 2022

Since this is a new API, I propose that we limit the dictionary of options to things that are definitely visibility related. It's easier to then add more options rather than remove questionable options later.

@css-meeting-bot
Copy link
Member

css-meeting-bot commented May 18, 2022

The CSS Working Group just discussed [cssom-view] isVisible inert option.

RESOLVED: Remove checkInert from IsVisibleOptions.

The full IRC log of that discussion <dbaron> Topic: [cssom-view] isVisible inert option
<dbaron> github: https://github.com//issues/7274
<dbaron> vmpstr: We have recently added an isVisible function to Element. It takes a dictionary of additional options. One of those options was about inert-ness.
<dbaron> vmpstr: Mozilla indicated that checking for inertness was a strange thing to correlate with visibility. So we'd like to remove this dictionary option, at least for now.
<dbaron> vmpstr: It's easier to add it later if people actually want this than to remove.
<Rossen_> q?
<dbaron> Rossen: I'm assuming this is relatively safe at this point?
<dbaron> vmpstr: I'm not aware of implementations.
<dbaron> Rossen: Did you consider oriol's question?
<dbaron> vmpstr: ... with aria-hidden? Rereading it now.
<dbaron> vmpstr: It's a good question, but we'd like to begin by shipping isVisible as a somewhat non-controversial set of options... questions such as these can be raised to add additional dictionary options if there are developers who want to check these things.
<chrishtr> +1 to removing
<dbaron> Rossen: Any objections to dropping dictionary for now?
<dbaron> vmpstr: Just dropping the inert-ness member from the dictionary.
<dbaron> Resolution: Remove checkInert from IsVisibleOptions.
<dbaron> Rossen: And hopefully oriol will get back to us if he has something to raise.

@josepharhar
Copy link
Contributor Author

@tabatkins would you mind removing the checkInert option from the spec? It looks like it's still up here: https://drafts.csswg.org/cssom-view/#dom-isvisibleoptions-checkinert

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants