-
Notifications
You must be signed in to change notification settings - Fork 707
[css-view-transitions-1] CSS selector keywords. #7960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Here's my 2c:
|
In your extended proposal, this is the element that creates hierarchy, right? That's exactly what groups do in SVG.
“list” has a very strong implication of “one or more, and probably many of an indeterminate number”, I think. Doesn't seem like a good fit for what is, afaict, only ever going to be two images (one of which might be empty)?
Are you thinking there will be three images in some future revision? @_@ |
By extended proposal I think you mean Nested transition containers. And yes, this will be the element which will have other container/group elements as children with that proposal.
With the current API it can be 1 or 2 images. 1 in the case where a
That comment was just to note a consideration for future flexibility. Given that we have no extension planned that could have more than 2 nodes, please disregard it. The only argument against |
I think that's fine. It's not an empty image but we're still conceptually transitioning between old and new, it's just that there's no image for one of these. :) Anyway that's my take. |
Thanks for the feedback @fantasai.
|
The CSS Working Group just discussed
The full IRC log of that discussion<dael> Topic: css-view-transitions-1] CSS selector keywords.<dael> github: https://github.com//issues/7960 <fantasai> https://github.com//issues/7960 <dael> fantasai: This is about naming varios pseudo elements for view transitions. Proposal for almost all in the issue. Could probably resolve all except 4 <dael> astearns: Prop is take propsals for items 1, 2, 3, 5, 6 in the issue <dael> astearns: Objections on those names? <dael> RESOLVED: Accept the proposed resolutions for items 1, 2, 3, 5, & 6 <dael> fantasai: Item 4. view-transition-group we just accepted gives a grouping mech with a hierarchy. In item 4 it's a leaf with one or two images <dael> fantasai: It exists because need isolation for blending. Item 4 is to name that almost leaf grouping. List of names is the proposed ones <dael> fantasai: Names fall into two sets. Ones that include image, ones that have grouping word, and ones with both <PaulG> q+ <dael> astearns: And this will not be used as much as rest? <dael> fantasai: Yes <astearns> ack PaulG <dael> PaulG: Confirming these are pseudo element images snapshotted and will not hit ax tree or carry content? <dael> fantasai: Right <dael> PaulG: Thank you <dael> astearns: we're at time. We'll come back to the issue for the one remaining thing |
Rename everything based on resolution at w3c#7960. This also includes a tentative rename for page-transition-image-wrapper to keep the spec consistent.
The CSS Working Group just discussed
The full IRC log of that discussion<fantasai> Topic: [css-view-transitions-1] CSS selector keywords<fantasai> github: https://github.com//issues/7960 <fantasai> khush: This is about resolving on the selector keywords <fantasai> khush: last meeting we got through everything except #4 <fantasai> khush: This is a pseudo-element for providing isolation for blending the old and new snapshots <fantasai> khush: it's a leaf of the tree, only has old and new snapshots <fantasai> khush: In terms of suggestions for naming, using word 'effect' or 'image', something to indicate that only nodes under here are replaced elements <fantasai> khush: and need to disambiguate from view-transition-group() which cna change position/size, and can have other view-transition elements underneath it <fantasai> khush: if we go with view-transition-image-foo, what's foo? <fantasai> khush: Con of using "set" is that it doesn't indicate that DOM order matters, "list" makes it look like any number of elements but can only have two, and "pair" is nicest but sometimes there's only one element <fantasai> khush: e.g. if DOM element only exists on one side <fantasai> khush: but if we're okay with that, my proposal is view-transition-image-pair <Rossen_> fantasai: +1 to using a pair. conceptually you have two things being transitioned independently <Rossen_> ack fantasai <fantasai> fantasai: wrt image, i'm less sure <fantasai> JakeA: Tab wanted view-transition-images for brevity, but ppl didn't like plural <fantasai> fantasai: for brevity, could also drop the "image" part and just say "view-transition-pair" <fantasai> khush: "view-transition-group" and "view-transition-pair" not immediately obvious what's the difference <fantasai> khush: but I could go either way, "view-transition-pair" vs "view-transition-image-pair" <fantasai> Rossen_: I think group vs pair will clash for many non-native speakers, but wouldn't object <fantasai> JakeA: It's not something folks will select a lot, ppl will select it ... I don't know, if they want to remove isolation for some reason? <fantasai> Rossen_: even more reason to use a longer name <flackr> Agree with Rossen_, I have a slight preference for view-transition-image-pair for clarity <JakeA> +1 to image-pair <khush> +1 <fantasai> Rossen_: Proposed to resolve on view-transition-image-pair <fantasai> wfm <lea> as a non-native speaker, I don't think group and pair are that frequently confused. Are there languages that do not distinguish between group and pair? <ydaniv> +1 to image-pair <fantasai> Rossen_: objections? <fantasai> RESOLVED: view-transition-image-pair |
The spec already names this element as view-transition-image-pair so no edit needed. |
Forking this from #7788 to resolve on the exact keywords used in the selector.
Property used on DOM elements to tag them for independent animations:
view-transition-name
.The pseudo-element which directly originates from the root element and is the ancestor for all container elements. Options are:
html::view-transition
html::view-transition-root
Proposed Resolution:
html::view-transition
The pseudo-element which animates the size and position for tagged elements. Options are:
html::view-transition-container(*)
html::view-transition-group(*)
Proposed Resolution:
html::view-transition-group(*)
The pseudo-element which adds
isolation
for blending. Options are:html::view-transition-image-group(*)
html::view-transition-pair(*)
html::view-transition-effect-group(*)
html::view-transition-images(*)
html::view-transition-set(*)
html::view-transition-image-set(*)
html::view-transition-image-pair(*)
The pseudo-element which displays snapshot from the old DOM element. Options are:
html::view-transition-old(*)
Proposed Resolution:
html::view-transition-old(*)
The pseudo-element which displays snapshot from the new DOM element. Options are:
html::view-transition-new(*)
Proposed Resolution:
html::view-transition-new(*)
Please comment in case I missed an existing suggestion from #7788 or if you have any other suggestions.
Pasting fantasai's comment on 3,4:
::view-transition-image-group
to::view-transition-pair
because it's shorter (and not a hyphenated phrase) and avoids evoking the idea of groups in SVG, which it's not conceptually similar to::view-transition-container
to::view-transition-group
because it's shorter and evokes the idea of groups in SVG (which create hierarchy in the graphic elements)The downside of using "pair" is that it'll make it awkward if a future change needs a pseudo-element other than old/new under this element. It's not a pair anymore then. ^_^ But no hard preference there, we don't forsee anything that would add more pseudo-elements under this node right now.
I also didn't follow why the the element adding
isolation
isn't conceptually similar to SVG groups but the one which mirrors size/position of the DOM element is. @fantasai could you clarify?Regarding shorter names, the motivation to use
view-transition-image-group
/view-transition-image-pair
instead ofview-transition-group
/view-transition-pair
would be that the latter sounds similar toview-transition-container
. The "image" keyword there makes it obvious that it's a pair of replaced elements. We could go withview-transition-image-pair
instead ofview-transition-image-group
.The text was updated successfully, but these errors were encountered: