[css-scoping] First pass at adding :has-slotted
#10959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`assignedNodes` reference doesn’t work
tabatkins
requested changes
Sep 27, 2024
Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
noamr
pushed a commit
to noamr/csswg-drafts
that referenced
this pull request
Oct 2, 2024
* First pass at adding `:has-slotted` `assignedNodes` reference doesn’t work * Fix assignedNodes * Update css-scoping-1/Overview.bs Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com> * Fix --------- Co-authored-by: Tab Atkins Jr. <jackalmage@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #6867 we resolved to add
:has-slotted. This PR is a first pass to add this.The reference to
assignedNodes()reference doesn’t work, not sure why. 🤷🏽♀️There is another open PR by @keithamus but it adds
:has-slotted()instead, which is both considerably harder to implement, and not what the resolution is about. I did however include a note that this will be included in a future version.