Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[selectors-4] Make :active :hover and :focus-within work on the flat tree #1177

Closed
wants to merge 1 commit into from

Conversation

frivoal
Copy link
Collaborator

@frivoal frivoal commented Apr 6, 2017

They were incorrectly defined as applying to shadow-including descendants,
while the intent was for them to work on flat tree descendants

Closes #1135

…tree

They were incorrectly defined as applying to shadow-including descendants,
while the intent was for them to work on flat tree descendants

Closes w3c#1135
@tabatkins
Copy link
Member

Whoops, I just accidentally committed identical changes without seeing this PR. Sorry for wasting your time, Florian. :(

@tabatkins tabatkins closed this Apr 10, 2017
@frivoal
Copy link
Collaborator Author

frivoal commented Apr 11, 2017

Whoops, I just accidentally committed identical changes without seeing this PR. Sorry for wasting your time, Florian. :(

No pb, form my point of view, the effect is the same: I made a PR and the changes I wanted end up in the spec. That you end-up retying the same thing instead of just clicking merge isn't my problem :)

@frivoal frivoal deleted the selectors-flat-tree branch June 5, 2020 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
selectors-4 Current Work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants