[css-text-3] Move break-spaces from overflow-wrap to white-space #2841

frivoal · 2018-06-28T02:08:50Z

fantasai · 2018-06-28T06:43:10Z

Thanks! :D

Finally the CSS WG decided [1] to move back the 'break-spaces' value to the 'white-space' property. This makes the parsing logic easier than the previous approach of using the 'overflow-wrap' property. This new value prevents the white-space sequence to collapse and gives breaking opportunities after every preserved white-space. https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the end of a line cannot be hung or visually collapsed, since we want them to be preserved and broken. [1] w3c/csswg-drafts#2841 Bug: 767634 Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67

Finally the CSS WG decided [1] to move back the 'break-spaces' value to the 'white-space' property. This makes the parsing logic easier than the previous approach of using the 'overflow-wrap' property. This new value prevents the white-space sequence to collapse and gives breaking opportunities after every preserved white-space. https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the end of a line cannot be hung or visually collapsed, since we want them to be preserved and broken. [1] w3c/csswg-drafts#2841 Bug: 767634 Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 Reviewed-on: https://chromium-review.googlesource.com/c/1136543 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#623324}

…es' for the white-space property", a=testonly Automatic update from web-platform-tests Revert "[css-text] New value 'break-spaces' for the white-space property" This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550 Sample Failed Step: compile Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Cr-Commit-Position: refs/heads/master@{#623324} Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767634 Reviewed-on: https://chromium-review.googlesource.com/c/1415914 Cr-Commit-Position: refs/heads/master@{#623339} -- wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764 wpt-pr: 14904

…s' for the white-space property, a=testonly Automatic update from web-platform-tests Reland [css-text] New value 'break-spaces' for the white-space property This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea The build failure that caused the revert has been fixed in https://crrev.com/c/1430010 TBR=kojii@chromium.org Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Cr-Commit-Position: refs/heads/master@{#623324} Bug: 767634 Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4 Reviewed-on: https://chromium-review.googlesource.com/c/1415254 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#625718} -- wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2 wpt-pr: 15042

…the white-space property, a=testonly Automatic update from web-platform-tests [css-text] New value 'break-spaces' for the white-space property Finally the CSS WG decided [1] to move back the 'break-spaces' value to the 'white-space' property. This makes the parsing logic easier than the previous approach of using the 'overflow-wrap' property. This new value prevents the white-space sequence to collapse and gives breaking opportunities after every preserved white-space. https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the end of a line cannot be hung or visually collapsed, since we want them to be preserved and broken. [1] w3c/csswg-drafts#2841 Bug: 767634 Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 Reviewed-on: https://chromium-review.googlesource.com/c/1136543 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#623324} -- wpt-commits: 250f9793781f3dcab7f7a3ee9d22cbdf707bdf68 wpt-pr: 13720

…es' for the white-space property", a=testonly Automatic update from web-platform-tests Revert "[css-text] New value 'break-spaces' for the white-space property" This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550 Sample Failed Step: compile Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Cr-Commit-Position: refs/heads/master@{#623324} Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767634 Reviewed-on: https://chromium-review.googlesource.com/c/1415914 Cr-Commit-Position: refs/heads/master@{#623339} -- wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764 wpt-pr: 14904

…s' for the white-space property, a=testonly Automatic update from web-platform-tests Reland [css-text] New value 'break-spaces' for the white-space property This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea The build failure that caused the revert has been fixed in https://crrev.com/c/1430010 TBR=kojii@chromium.org Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Cr-Commit-Position: refs/heads/master@{#623324} Bug: 767634 Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4 Reviewed-on: https://chromium-review.googlesource.com/c/1415254 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#625718} -- wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2 wpt-pr: 15042

…the white-space property, a=testonly Automatic update from web-platform-tests [css-text] New value 'break-spaces' for the white-space property Finally the CSS WG decided [1] to move back the 'break-spaces' value to the 'white-space' property. This makes the parsing logic easier than the previous approach of using the 'overflow-wrap' property. This new value prevents the white-space sequence to collapse and gives breaking opportunities after every preserved white-space. https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the end of a line cannot be hung or visually collapsed, since we want them to be preserved and broken. [1] w3c/csswg-drafts#2841 Bug: 767634 Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 Reviewed-on: https://chromium-review.googlesource.com/c/1136543 Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#623324} -- wpt-commits: 250f9793781f3dcab7f7a3ee9d22cbdf707bdf68 wpt-pr: 13720

…es' for the white-space property", a=testonly Automatic update from web-platform-tests Revert "[css-text] New value 'break-spaces' for the white-space property" This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550 Sample Failed Step: compile Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Cr-Commit-Position: refs/heads/master@{#623324} Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767634 Reviewed-on: https://chromium-review.googlesource.com/c/1415914 Cr-Commit-Position: refs/heads/master@{#623339} -- wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764 wpt-pr: 14904

…s' for the white-space property, a=testonly Automatic update from web-platform-tests Reland [css-text] New value 'break-spaces' for the white-space property This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea The build failure that caused the revert has been fixed in https://crrev.com/c/1430010 TBR=kojii@chromium.org Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Commit-Queue: Javier Fernandez <jfernandez@igalia.com> > Cr-Commit-Position: refs/heads/master@{#623324} Bug: 767634 Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4 Reviewed-on: https://chromium-review.googlesource.com/c/1415254 Reviewed-by: Javier Fernandez <jfernandez@igalia.com> Reviewed-by: Koji Ishii <kojii@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#625718} -- wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2 wpt-pr: 15042

https://bugs.webkit.org/show_bug.cgi?id=177327 Reviewed by Myles Maxfield and Zalan Bujtas. LayoutTests/imported/w3c: Imoprted a few aditional tests from the CSS Text WPT suite that are relevant for this change. * web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-008-expected.html: Added. * web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-008.html: Added. * web-platform-tests/css/css-text/overflow-wrap/w3c-import.log: * web-platform-tests/css/css-text/parsing/white-space-valid-expected.txt: * web-platform-tests/css/css-text/white-space/break-spaces-003-expected.html: Added. * web-platform-tests/css/css-text/white-space/break-spaces-003.html: Added. * web-platform-tests/css/css-text/white-space/break-spaces-009-expected.html: Added. * web-platform-tests/css/css-text/white-space/break-spaces-009.html: Added. * web-platform-tests/css/css-text/white-space/w3c-import.log: Source/WebCore: Finally the CSS WG decided [1] to move back the 'break-spaces' value to the 'white-space' property. This makes the parsing logic easier than the previous approach of using the 'overflow-wrap' property. This new value prevents the white-space sequence to collapse and gives breaking opportunities after every preserved white-space. https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the end of a line cannot be hung or visually collapsed, since we want them to be preserved and broken. [1] w3c/csswg-drafts#2841 Tests: imported/w3c/web-platform-tests/css/css-text/overflow-wrap/overflow-wrap-break-word-008.html imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-003.html imported/w3c/web-platform-tests/css/css-text/white-space/break-spaces-009.html * css/CSSPrimitiveValueMappings.h: (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): New mapping for CSSVaueBreakSpaces. (WebCore::CSSPrimitiveValue::operator WhiteSpace const): New value BreakSpaces for the Whitespace enum. * css/CSSProperties.json: new 'break-spaces' value for the 'white-space' property. * css/CSSValueKeywords.in: new break-spaces keyword * css/parser/CSSParserFastPaths.cpp: (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue): * rendering/SimpleLineLayout.cpp: The SimpleLineLayut codepath must handle properly the new behavior of preserved whitespaces. (WebCore::SimpleLineLayout::LineState::hasTrailingWhitespace const): Require that m_trailingWhitespaceWidth being greater than zero. (WebCore::SimpleLineLayout::LineState::hasWhitespaceFragments const): New function to detect former whitespae fragments that could be breaking opportunities. (WebCore::SimpleLineLayout::removeTrailingWhitespace): The 'break-spaces' feature forbids to remove any trailing whitespace. (WebCore::SimpleLineLayout::firstFragment): We have now leading whitespace sequences comming from the previous line. (WebCore::SimpleLineLayout::createLineRuns): We should revert some breaking opportunities if others were formerly found in the line. * rendering/SimpleLineLayoutTextFragmentIterator.cpp: (WebCore::SimpleLineLayout::TextFragmentIterator::Style::Style): New style fields to determine whether the break-space feature is being used. Also split out the break-all and breal-all values. * rendering/SimpleLineLayoutTextFragmentIterator.h: * rendering/line/BreakingContext.h: Different codepath but similar changes to properly handle the new behavior of preserved whitespace. (WebCore::BreakingContext::BreakingContext): New class field to determine whether there are some whitespace that may prevent the word ot be broken. (WebCore::BreakingContext::handleText): New line-breaking logic to implement the break-spaces behavior. (WebCore::BreakingContext::trailingSpacesHang): Cases where the preserved breakspaces should hand or overflow. * rendering/style/RenderStyle.h: (WebCore::RenderStyle::collapseWhiteSpace): With break-spaces collapsing whitespaces is not allowed. (WebCore::RenderStyle::breakOnlyAfterWhiteSpace const): Add the WhiteSpace::BreakSpaces to this group. * rendering/style/RenderStyleConstants.h: A new constan added. LayoutTests: Removed many failure expectations of tests that pass now thanks to this change. The overflow-wrap-break-word-003.html tests fails in mac and iOS platforms due to an issue related to how we compute widths using 'ch' units and 'monospace' fonts. I filed bug #196169 to report the specific case of this test (break-word+pre-wrap) but the root cause it's probably the bug #196353. I have submitted a PR [1] to the Web Platform Tests to change several tests that failed only if the monospace font is used, but pass with the Ahem font. Additionally, I've requested another PR [2] to add new layout tests, with the same case than overflow-wrap-break-word-003.html but using the Ahem font. [1] web-platform-tests/wpt#16137 [2] web-platform-tests/wpt#16124 * TestExpectations: Removed many Failure entries on tests that pass now thanks to this change. * platform/mac/TestExpectations: Added one Failure entry and filed the corresponding bug report. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@244036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

…the white-space property, a=testonly Automatic update from web-platform-tests [css-text] New value 'break-spaces' for the white-space property Finally the CSS WG decided [1] to move back the 'break-spaces' value to the 'white-space' property. This makes the parsing logic easier than the previous approach of using the 'overflow-wrap' property. This new value prevents the white-space sequence to collapse and gives breaking opportunities after every preserved white-space. https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the end of a line cannot be hung or visually collapsed, since we want them to be preserved and broken. [1] w3c/csswg-drafts#2841 Bug: 767634 Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 Reviewed-on: https://chromium-review.googlesource.com/c/1136543 Reviewed-by: Koji Ishii <kojiichromium.org> Commit-Queue: Javier Fernandez <jfernandezigalia.com> Cr-Commit-Position: refs/heads/master{#623324} -- wpt-commits: 250f9793781f3dcab7f7a3ee9d22cbdf707bdf68 wpt-pr: 13720 UltraBlame original commit: 0a5612bfa515b9d702bdd566f0bfe67161d07e3f

…es' for the white-space property", a=testonly Automatic update from web-platform-tests Revert "[css-text] New value 'break-spaces' for the white-space property" This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550 Sample Failed Step: compile Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojiichromium.org> > Commit-Queue: Javier Fernandez <jfernandezigalia.com> > Cr-Commit-Position: refs/heads/master{#623324} Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767634 Reviewed-on: https://chromium-review.googlesource.com/c/1415914 Cr-Commit-Position: refs/heads/master{#623339} -- wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764 wpt-pr: 14904 UltraBlame original commit: 0ac6eb09ec8443286bc19d708f8be6ae7a094f3c

…s' for the white-space property, a=testonly Automatic update from web-platform-tests Reland [css-text] New value 'break-spaces' for the white-space property This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea The build failure that caused the revert has been fixed in https://crrev.com/c/1430010 TBR=kojiichromium.org Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojiichromium.org> > Commit-Queue: Javier Fernandez <jfernandezigalia.com> > Cr-Commit-Position: refs/heads/master{#623324} Bug: 767634 Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4 Reviewed-on: https://chromium-review.googlesource.com/c/1415254 Reviewed-by: Javier Fernandez <jfernandezigalia.com> Reviewed-by: Koji Ishii <kojiichromium.org> Commit-Queue: Javier Fernandez <jfernandezigalia.com> Cr-Commit-Position: refs/heads/master{#625718} -- wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2 wpt-pr: 15042 UltraBlame original commit: 7c663c7d9cdde647624efea7d96be0d6a5fccd3b

…the white-space property, a=testonly Automatic update from web-platform-tests [css-text] New value 'break-spaces' for the white-space property Finally the CSS WG decided [1] to move back the 'break-spaces' value to the 'white-space' property. This makes the parsing logic easier than the previous approach of using the 'overflow-wrap' property. This new value prevents the white-space sequence to collapse and gives breaking opportunities after every preserved white-space. https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the end of a line cannot be hung or visually collapsed, since we want them to be preserved and broken. [1] w3c/csswg-drafts#2841 Bug: 767634 Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 Reviewed-on: https://chromium-review.googlesource.com/c/1136543 Reviewed-by: Koji Ishii <kojiichromium.org> Commit-Queue: Javier Fernandez <jfernandezigalia.com> Cr-Commit-Position: refs/heads/master{#623324} -- wpt-commits: 250f9793781f3dcab7f7a3ee9d22cbdf707bdf68 wpt-pr: 13720 UltraBlame original commit: d3fbc71412c581b84a8ce2919bbb70c5f153e1d9

…es' for the white-space property", a=testonly Automatic update from web-platform-tests Revert "[css-text] New value 'break-spaces' for the white-space property" This reverts commit a07642661ef7ff08c156e90394504a3a40afc9ea. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 623324 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2EwNzY0MjY2MWVmN2ZmMDhjMTU2ZTkwMzk0NTA0YTNhNDBhZmM5ZWEM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win%20x64%20Builder/60550 Sample Failed Step: compile Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojiichromium.org> > Commit-Queue: Javier Fernandez <jfernandezigalia.com> > Cr-Commit-Position: refs/heads/master{#623324} Change-Id: If430ec5653a3e50bc3711fa94f6b535589270b0c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 767634 Reviewed-on: https://chromium-review.googlesource.com/c/1415914 Cr-Commit-Position: refs/heads/master{#623339} -- wpt-commits: bab060aea663d136ad54dfee073c6f2f3688a764 wpt-pr: 14904 UltraBlame original commit: a3e0b0f31f388629e8fd27ea64d50d142b70bc50

…s' for the white-space property, a=testonly Automatic update from web-platform-tests Reland [css-text] New value 'break-spaces' for the white-space property This is a reland of a07642661ef7ff08c156e90394504a3a40afc9ea The build failure that caused the revert has been fixed in https://crrev.com/c/1430010 TBR=kojiichromium.org Original change's description: > [css-text] New value 'break-spaces' for the white-space property > > Finally the CSS WG decided [1] to move back the 'break-spaces' value to > the 'white-space' property. This makes the parsing logic easier than > the previous approach of using the 'overflow-wrap' property. > > This new value prevents the white-space sequence to collapse and gives > breaking opportunities after every preserved white-space. > > https://drafts.csswg.org/css-text-3/#valdef-white-space-break-spaces > > Additionally, unlike 'pre-wrap', non-collapsible spaces or tabs at the > end of a line cannot be hung or visually collapsed, since we want them > to be preserved and broken. > > [1] w3c/csswg-drafts#2841 > > Bug: 767634 > Change-Id: I55e888d4472de11c64c4b14e2710c6e3d1832e67 > Reviewed-on: https://chromium-review.googlesource.com/c/1136543 > Reviewed-by: Koji Ishii <kojiichromium.org> > Commit-Queue: Javier Fernandez <jfernandezigalia.com> > Cr-Commit-Position: refs/heads/master{#623324} Bug: 767634 Change-Id: I987214a1b1275bfcc34cb2cadb2089344c4a7da4 Reviewed-on: https://chromium-review.googlesource.com/c/1415254 Reviewed-by: Javier Fernandez <jfernandezigalia.com> Reviewed-by: Koji Ishii <kojiichromium.org> Commit-Queue: Javier Fernandez <jfernandezigalia.com> Cr-Commit-Position: refs/heads/master{#625718} -- wpt-commits: 2e3722e50cb8fd2e3c70629c2ca2607e79c6d5e2 wpt-pr: 15042 UltraBlame original commit: 3a07c188580757a430272d1f59502ba5426c9a7f