Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-tables-3] Remove invisible symbols in <'border-spacing'> syntax definition #4275

Merged
merged 1 commit into from
Sep 7, 2019
Merged

[css-tables-3] Remove invisible symbols in <'border-spacing'> syntax definition #4275

merged 1 commit into from
Sep 7, 2019

Conversation

lahmatiy
Copy link
Contributor

@lahmatiy lahmatiy commented Sep 4, 2019

Removed symbols even not visible on GitHub's diff view.
The diff from GitHub Desktop client:
image

@lahmatiy
Copy link
Contributor Author

lahmatiy commented Sep 4, 2019

Marked as non substantive for IPR from ash-nazg.

@FremyCompany
Copy link
Contributor

Lol, how did they even get there, and how did you figure that out? 😀

@FremyCompany FremyCompany merged commit 000e54d into w3c:master Sep 7, 2019
@FremyCompany FremyCompany mentioned this pull request Sep 7, 2019
Merged
@FremyCompany
Copy link
Contributor

Oh, I had to revert, because if I remove them, <length> becomes an html element and disappears entirely. Maybe @tabatkins know what the proper fix would be?

@lahmatiy
Copy link
Contributor Author

lahmatiy commented Sep 7, 2019

Oh, forgot about it. Yep, it must be <<length>> then.

@lahmatiy
Copy link
Contributor Author

lahmatiy commented Sep 7, 2019 •
edited
Loading

how did you figure that out?

Recently I started a project — csswg-drafts-index. It parses this repo's specs in a JSON dictionary. So I found all propdef and descdef blocks and parsed Value and New value values with CSSTree, which can work with CSS definition syntax. As a result I found some issues, that were addressed with this PR and #4274. Later I grabbed most productions and parsed their syntaxes, and found a couple of problems (not send PRs to address them yet). Current problem syntaxes can be observed in this report (note: by incident, I published a version where issues from #4274 are fixed; however, these fixes are not merged yet)

@FremyCompany
Copy link
Contributor

Super cool project!

I'll make the correct fix eventually, maybe during tpac.

@lahmatiy lahmatiy mentioned this pull request Feb 11, 2021
Closed
tidoust added a commit to tidoust/csswg-drafts that referenced this pull request Mar 4, 2021
@tidoust
[css-tables-3] Drop zero-width spaces in border-spacing dfn
a3ff410 
This addresses the syntax issue raised in w3c#4275 (which got merged then
reverted because `<>` have to be doubled in practice). The goal of the update
is to make the definition compliant with the Value Definition Syntax:
https://www.w3.org/TR/css-values-4/#value-defs
@tidoust tidoust mentioned this pull request Mar 4, 2021
Merged
FremyCompany pushed a commit that referenced this pull request Mar 4, 2021
@tidoust @FremyCompany
[css-tables-3] Drop zero-width spaces in border-spacing dfn
695696e 
This addresses the syntax issue raised in #4275 (which got merged then
reverted because `<>` have to be doubled in practice). The goal of the update
is to make the definition compliant with the Value Definition Syntax:
https://www.w3.org/TR/css-values-4/#value-defs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewilligers ewilligers ewilligers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lahmatiy @FremyCompany @ewilligers