Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-cssom-view-1] Introduce scrollend and overscroll events #4537

Closed
wants to merge 1 commit into from

Conversation

NavidZ
Copy link
Member

@NavidZ NavidZ commented Nov 25, 2019

[css-spec-shortname-1] Introduce scrollend and overscroll events

This proposal fixes the #3801 issue. It merges the proposed new events from WICG repo into the main spec.

@NavidZ
Copy link
Member Author

NavidZ commented Nov 25, 2019

The tests are added under wpt/dom/events/scrolling.

@NavidZ
Copy link
Member Author

NavidZ commented Nov 25, 2019

@smaug---- @SamFort-MSFT @smfr FYI
I tried to capture the details we had discussed in the email as well so hopefully there is nothing missing. But please take another look and see whether you are okay with the text as is or you would like to add anything.

@annevk
Copy link
Member

annevk commented Apr 6, 2020

This should define integration with the event loop better. In particular any reactions to some abstract notion of "kernel input" need to queue a task.

Copy link

@staktrace staktrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be valuable to clarify somewhere whether the overscroll event gets fired even if there is no visual effect (e.g. rubberbanding) applied to the document. Otherwise people may assume that overscroll is only fired when there is a user-visible overscroll effect.

1. If <var>doc</var> is already in <var>doc</var>'s <a>pending scroll event targets</a>, abort these steps.
1. Append <var>doc</var> to <var>doc</var>'s <a>pending scroll event targets</a>.
1. If a <a>viewport</a> is getting scrolled, let <var>doc</var> be the <a>viewport’s</a> associated {{Document}} and <var>target</var> be the <a>viewport</a>.
Otherwise, an element is gettings scolled and let <var>doc</var> be the element's <a>node document</a> and <var>target</var> be the element.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: /gettings scolled/getting scrolled/

@chrishtr
Copy link
Contributor

chrishtr commented Oct 6, 2022

Closing as not being worked on. Also, @argyleink already landed a commit to add scrollend.

@chrishtr chrishtr closed this Oct 6, 2022
@smfr
Copy link
Contributor

smfr commented Oct 7, 2022

Have we specified the web-exposed behavior for overscroll anywhere (e.g. whether scrollTop etc go negative)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants