-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding of video-* properties and dynamic-range to handle bi-plane scenarios #4678
Conversation
comment moved to issue |
It would of course be great to reference some widely agreed definition of High Dynamic Range or Wide Color Gamut as they pertain to display capabilities. However, I'm not aware that any such thing exists. Given any candidate for such a thing, someone will make a display that is 1 nit less bright or has 0.1% P3 smaller gamut and claim (accurately) that the experience on that display is just as deserving of the moniker. In any case, the question that the site wishes to answer with these properties is whether the user experience will be better if the HDR / WCG version of the content is provided (and mapped down to the display capability) than if the SDR / NCG version is provided (and mapped up to the display capability). This of course is a matter of opinion. The opinion that matters in this case is the users (or, some may argue, the filmmakers). So, I think the best we can do is ask the user's agent to answer this question on behalf of the user. |
@gregwhitworth I'm nt worried enough to want to hold up this PR |
So I think we can merge this? |
…t contrast of the display should be defined by the UA
@svgeesus I made your modifications you asked for. I also added some non-normative text regarding the current state of handling contrast of the display that I'd like you to review quickly. If you're fine with all of that please merge it in. |
@gregwhitworth thanks for that, all looks good to me. I pinged @frivoal just as the CSSWG f2f was ending, he wants to review more closely and perhaps tighten some wording before merging. |
Sorry folks, I'm late to the party. Let me make a pass on the language real quick. |
…emoving color gamut for dynamic-range
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for all the comments. I took a well caffeinated look at this and I had lots to say. Maybe too much.
@chcunningham Thanks for your comments. They should all be addressed -- let me know if issues remain. cc: @gregwhitworth @gregwfreedman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vi. Some small follow ups, but I think this is nearly there.
mediaqueries-4/Overview.bs
Outdated
|
||
High dynamic range (HDR) represents the combination of brightness, color depth, transfer function, and color gamut. | ||
|
||
<dl dfn-type=value dfn-for="video-dynamic-range"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(repasting so this doesn't git hidden in the resolved thread)
Now that you're referencing the values for non-prefixed dynamic-range, you can remove this whole dfn block of value definitions and just rely on the reference. This is consistent with video-color-gamut.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git hidden
:)
Ah, thanks -- I had missed some of the more obvious edits. The latest commit should address your CR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Vi. Approved % two final comments.
Thanks Chris! |
Ok, since we've gotten @chcunningham sign off I'd like to get a review from @frivoal since @svgeesus mentioned he'd like to provide some feedback. |
That would be nice, but the recent changes have improved this nicely so I would also be fine with merging as-is. |
Hi @gregwhitworth, I'm sorry for being so far behind. I do have some feedback, which I'll put it here first, but depending on responses it'll make its way into separate issues / PRs. procedural / editorial
Substantive
Depending on the responses to the points above, I might file issues / PRs differently, but for now, I expect I'll probably directly commit on the master branch for the first 2 points, propose PRs for the next 2, and to open a new issue for the last one. |
Hi @frivoal. Thank you for your review -- your feedback loos good to me and I trust your purview here. Am I understanding correctly that you intend to make Pull Requests for these proposals? P.S. I hope you are well. |
hi @frivoal. thanks for reviewing. i agree with your first four points. with respect to
i think that was just to be consistent with other CSS features. the only intent of |
As resolved in issue #4471 I have added in:
And a brief description of the issue along with normative text of when to answer differently between a single or bi-plane scenario.
Specific to dynamic-range we placed a general definition there and are interested in thoughts since standard & high may fluctuate over time but I'd expect the spec text too as well.